fix: bound configurable deadlines to the Node timer range - #212
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: bound configurable deadlines to the Node timer range This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A configured timeout above 2,147,483,647 ms overflows Node's timer range and becomes a one-millisecond deadline. Provider, validation, and PR-publishing operations could therefore be killed immediately despite an apparently long timeout.
User Impact
Out-of-range timeout overrides use the existing safe default. Valid fractional delays are truncated, and provider-specific settings still take precedence over the global provider timeout.
Why This Change Was Made
Share one bounded timer parser across provider checks/execution, validation, PR publishing, Go discovery, and Windows process cleanup. This keeps the previously bounded Go/Windows behavior and prevents other execution paths from diverging.
Evidence
2147483648emitsTimeoutOverflowWarning, gets a 1 ms deadline, and exits 124.readywith exit 0.pnpm typecheck,pnpm lint, provider/publishing/process/Go tests (38 passed, 2 existing platform skips), andpnpm buildpass.