Release testing clean-up: example deployment target + bundle identifier#959
Open
w-goog wants to merge 1 commit into
Open
Release testing clean-up: example deployment target + bundle identifier#959w-goog wants to merge 1 commit into
w-goog wants to merge 1 commit into
Conversation
- Example-iOS_ObjC/Podfile: bump platform :ios from 11.0 to 12.0 to match the podspec minimum deployment target (iOS 12 since 2.0.0); pod install otherwise fails to resolve the AppAuth dependency. - Example-iOS_Swift-SPM: remove the hardcoded PRODUCT_BUNDLE_IDENTIFIER from the Xcode project so the bundle identifier is supplied via Config/Example.local.xcconfig, matching how the OAuth client values are set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up two example-app configuration issues that came up whilst testing the 2.1.0 release packaging.
Bump
platform :iosfrom11.0to12.0. AppAuth's podspec has required iOS 12 since 2.0.0 (#918), sopod installon the sample app currently fails with "Specs satisfying theAppAuthdependency were found, but they required a higher minimum deployment target."Remove the hardcoded
PRODUCT_BUNDLE_IDENTIFIERfrom the Xcode project so the bundle identifier is driven byConfig/Example.local.xcconfig(the gitignored local override), which was accidentally checked in. The value was already public, as it is in the site associations file, so further scrubbing is not required.Tested that
pod install+ iOS Simulator build & launch ofExample-iOS_ObjCsucceed with the bumped Podfile.