Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,16 @@ jobs:
with:
persist-credentials: false

# setup-java's problem matcher turns javac's warnings, Error Prone's among them, into annotations on
# the diff. This is the one job that keeps it: every other job compiles the same sources, and with
# the matcher on there too each warning showed once per job. GitHub keeps only the first ten
# warnings of a step, so the annotations are the first ten warnings the parallel build prints.
- name: Install JDK 21
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: temurin
java-version: '21'
problem-matcher: true

- name: Build
run: ./gradlew test
Expand Down Expand Up @@ -68,19 +73,22 @@ jobs:
with:
persist-credentials: false

# No problem matcher in this job: `build` annotates the warnings.
- name: Install JDK ${{ matrix.jdk }} for the tests
id: test-jdk
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: temurin
java-version: ${{ matrix.jdk }}
problem-matcher: false

# Installed last, so that it is the JAVA_HOME Gradle runs and compiles on.
- name: Install JDK 21
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: temurin
java-version: '21'
problem-matcher: false

- name: Explain the extra Gradle arguments
if: ${{ matrix.gradle_args != '' }}
Expand Down Expand Up @@ -138,13 +146,15 @@ jobs:

# The jars compile with a Java 21 toolchain, which gradle.properties looks up in JDK21_HOME. On
# Linux and macOS Gradle also finds the runner's own JDK 21 by its location, on Windows it does not.
# Installed before GraalVM, so that Gradle itself still runs on GraalVM.
# Installed before GraalVM, so that Gradle itself still runs on GraalVM. No problem matcher: `build`
# annotates the warnings.
- name: Install JDK 21 for the jars
id: jdk21
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: temurin
java-version: '21'
problem-matcher: false

- name: Install GraalVM 25 for the image
uses: graalvm/setup-graalvm@0426e2e191540e8514dff98dc52a5f5146a2a276 # v1.6.6
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ jobs:
with:
persist-credentials: false

# No problem matcher: the javac warnings are annotated by CI's `build` job.
- name: Set up JDK 21
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: temurin
java-version: '21'
problem-matcher: false

- name: Initialize CodeQL
uses: github/codeql-action/init@1c5b675653bb5c22dbe9b12b556ec555138e09fd # v4.38.1
Expand Down
Loading