Potential fix for 1 code quality finding - #15
Merged
matteius merged 1 commit intoAug 3, 2026
Conversation
…pilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the get_saml_config() docstring to document an intentional SAML compatibility default: security.wantAttributeStatement is set to False to support IdPs (e.g., common Google SAML configurations) that may not include an AttributeStatement.
Changes:
- Added a docstring “Compatibility note” explaining why
wantAttributeStatementdefaults toFalse. - Documented that projects can override the default
securityconfiguration viaFORMS_WORKFLOWS_SAML["security"].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matteius
marked this pull request as ready for review
August 3, 2026 20:50
matteius
deleted the
ai-findings-autofix/django_forms_workflows-sso_backends.py
branch
August 3, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 1/4 suggestions from code quality AI findings. 3 suggestions were skipped to avoid creating conflicts.