Convert workflow builder to module - #17
Merged
matteius merged 3 commits intoAug 5, 2026
Merged
Conversation
getNodeDescription() and buildFormProperties() had unescaped values that would likely get picked up by copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts the workflow-builder.js static asset from a classic-script global to an ES module export, updates the Django admin template to import it as a module, and adds regression tests to ensure key workflow-builder UI strings are properly HTML-escaped to prevent XSS.
Changes:
- Export
WorkflowBuilderas an ES module and remove thewindow.WorkflowBuilderglobal assignment. - Update
workflow_builder.htmltoimport { WorkflowBuilder }from the static asset via a<script type="module">. - Add Vitest + JSDOM tests covering module import wiring and escaping regressions in
getNodeDescription()andbuildFormProperties().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests_js/workflow-builder/moduleAndEscaping.test.js | Adds module-wiring and XSS-escaping regression tests for key builder-rendered HTML. |
| django_forms_workflows/templates/admin/django_forms_workflows/workflow_builder.html | Switches admin initialization to a module script that imports WorkflowBuilder instead of relying on a global. |
| django_forms_workflows/static/django_forms_workflows/js/workflow-builder.js | Exports WorkflowBuilder as an ES module and escapes additional interpolated fields in rendered HTML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts workflow builder to module, fixes escaping all at once (so copilot doesn't tag each module as it goes in), and adds first battery of tests for workflow builder