NE-2520: Promote GatewayAPIWithoutOLM to GA

[gcs278]

This PR promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default (GA).

Background

The GatewayAPIWithoutOLM feature replaces the OLM-based Istio installation method with direct Helm chart installation via the Sail library, enabling Gateway API support on clusters without OLM/Marketplace capabilities and avoiding conflicts with existing OSSM subscriptions.

Related Work

• Enhancement: NE-2470: Gateway API without OLM
• Implementation: cluster-ingress-operator#1354
• Jira Epic: NE-2520

Testing

• Sippy: GatewayAPIWithoutOLM Results
• Existing E2E tests adapted in cluster-ingress-operator gateway_api_test.go for more coverage
• Upgrade test: origin#30897 validates OLM to NO-OLM migration; tested manually (TechPreview clusters cannot be upgraded in CI), will merge soon and shouldn't block promotion

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE: Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8e7ffeb7-bd69-46ed-8274-abcaf9bdf489

📥 Commits

Reviewing files that changed from the base of the PR and between 64340c4 and 71580b7.

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

✅ Files skipped from review due to trivial changes (1)

• features.md

🚧 Files skipped from review as they are similar to previous changes (3)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

📝 Walkthrough

Walkthrough

The GatewayAPIWithoutOLM feature gate is enabled in additional contexts. The feature gate registration in features/features.go now includes inDefault() and inOKD() alongside inDevPreviewNoUpgrade() and inTechPreviewNoUpgrade(). Corresponding payload feature-gate YAMLs for Hypershift and SelfManagedHA (Default and OKD variants) move GatewayAPIWithoutOLM from status.featureGates[].disabled to status.featureGates[].enabled. features.md reorders the GatewayAPIWithoutOLM row in the feature table.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e01ef8c0-2309-11f1-813c-239011e41911-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0198a9d0-233f-11f1-9a7d-ebebc862b301-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07dadcd0-2391-11f1-8c59-fe2512e5aad1-0

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ab81910-23c6-11f1-8635-bf728c1f5aad-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e4a3720-2406-11f1-93e5-9f16732fd0e5-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ddd5ec0-2493-11f1-8cf8-effe9a495bea-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69a77f80-24c8-11f1-9403-ad1a7c99fb97-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a761690-24c8-11f1-9c74-da2cb51d6692-0

[openshift-ci-robot]

@gcs278: This pull request references NE-2561 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d5568f0-2710-11f1-9d03-561b26d4f2f7-0

[JoelSpeed]

/pipeline required

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[JoelSpeed]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[everettraven]

Yes, I'm certain. Though we do claim support for Metal/VSphere (NE-2010), we do not claim support for IPv6 and DualStack for the entire Gateway API feature. We don't run tests on it today, and when I tried to enable it for IPv6, Gateway API doesn't work. And my feature (GatewayAPIWithoutOLM) is a "child feature" that is dependent on Gateway API functioning.

Thanks for the additional context.

would you consider allowing us to promote? I did the math, and we'd need 24 more tests to succeed in a row to get back to 95%. I don't think we have quite that runway at the moment. I could gangway the Vsphere tests, but it'd seem a bit hard on our VSphere resources (i'd need to run 6-7 times a day to get in by branch cut). I'm confident the VSphere feature functionality is working as expected.

My stance would be:

• Let's get the flake fix in and gather enough more recent runs to build confidence that the flake no longer happens
• Get the 95% pass rate OR have good signal towards 95% pass rate AND get an ACK from TRT and/or OCP Architects that they are OK with this going in with a lower pass rate for this platform. Keep in mind that anything with less than a 95% pass rate is considered a regression. Regressions cause issues when trying to get release candidates and the purpose of the "pencils down" is to start focusing on stability in preparation for getting release candidates out. The 95% passing rate rule is meant to ensure we aren't introducing instability here and without an explicit ACK from the ones impacted by instability that they are OK with this, I won't circumvent this requirement.

[gcs278]

@everettraven Thanks - I understand the caution here given the timeline. Getting to 95% likely isn't going to work given our desired timeline of making branch cut (and we'd like to merge in the next day or so). So we will need to get folks to sign off.

To help illustrate my confidence:

• The flake fix has merged OCPBUGS-81751: Fix GatewayClass update conflict in markTestDone origin#30964
• In the last 24 hours we've gone from 87% to 90% on the latest verify-feature-promotion run for the flakey test (Ensure GatewayClass contains sail finalizer after creation)
• The aggregate periodic job results for the flake fix OCPBUGS-81751: Fix GatewayClass update conflict in markTestDone origin#30964 showed that of the 4/10 vsphere clusters that installed successfully, none had the flake, and none had any GWAPI-related issues.
• It's worth repeating the context: the flake happened on a defer cleanup function, so the core content of the test itself actually passed, but flake happened at the end.

CC: @JoelSpeed

[JoelSpeed]

Given the above, and that the only failures visible in sippy are from test cleanup which we are now confident is fixed

/override ci/prow/verify-feature-promotion

/lgtm
/verified by verify-feature-promotion

/retest

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by verify-feature-promotion.

Details

In response to this:

Given the above, and that the only failures visible in sippy are from test cleanup which we are now confident is fixed

/override ci/prow/verify-feature-promotion

/lgtm
/verified by verify-feature-promotion

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

Details

In response to this:

Given the above, and that the only failures visible in sippy are from test cleanup which we are now confident is fixed

/override ci/prow/verify-feature-promotion

/lgtm
/verified by verify-feature-promotion

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD f50e695 and 2 for PR HEAD 71580b7 in total

[gcs278]

@JoelSpeed I think you'll need to re-apply the override.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD d87d63a and 1 for PR HEAD 71580b7 in total

[JoelSpeed]

/override ci/prow/verify-feature-promotion
/override ci/prow/e2e-aws-ovn-hypershift-conformance

HyperShift conformance has a known image configuration issue

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/verify-feature-promotion

Details

In response to this:

/override ci/prow/verify-feature-promotion
/override ci/prow/e2e-aws-ovn-hypershift-conformance

HyperShift conformance has a known image configuration issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/override ci/prow/e2e-azure

Failures appear to me to be unrelated

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure

Details

In response to this:

/override ci/prow/e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 8b086e6 and 0 for PR HEAD 71580b7 in total

[JoelSpeed]

/override ci/prow/verify-feature-promotion

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

Details

In response to this:

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.