SPLAT-2827: Added vSphere failure domain to vcenter check by vr4manta · Pull Request #2932 · openshift/api

vr4manta · 2026-07-14T12:21:13Z

Changes

Added checks to vCenter infrastructure spec to make sure that all failure domains have a vCenter configured int he vCenters section

Notes

These changes are being gated behind the VSphereMultiVCenterDay2 feature gate

openshift-merge-bot · 2026-07-14T12:21:15Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-07-14T12:21:17Z

@vr4manta: This pull request references SPLAT-2827 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

SPLAT-2827

Changes

Added checks to vCenter infrastructure spec to make sure that all failure domains have a vCenter configured int he vCenters section

Notes

These changes are being gated behind the VSphereMultiVCenterDay2 feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-14T12:21:23Z

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-07-14T12:21:37Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Added a feature-gated vSphere validation rule requiring every non-empty failure domain to reference a configured vCenter with the same server value. Propagated the rule to infrastructure and controller configuration CRD manifests. Added create and update test cases for matching, missing, removed, shared, and case-mismatched server references. Updated existing vSphere network fixtures and added an AGENTS.md reference to CLAUDE.md.

Suggested reviewers: sinnykumari, joelspeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: adding a vSphere failure domain to vCenter validation.
Description check	✅ Passed	The description is clearly related to the change and correctly mentions the vCenter/failure domain validation and feature gate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Added test titles are fixed, descriptive strings; no dynamic values, timestamps, UUIDs, IPs, or generated names appear in the titles.
Test Structure And Quality	✅ Passed	Fixture-only YAML tests follow existing one-scenario-per-case style; no Ginkgo blocks, cluster ops, or timeout/cleanup concerns are introduced.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes CRD schema/validation fixtures, so the MicroShift test check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes YAML schema fixtures and generated CRDs, so SNO-specific test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only vSphere CRD/CEL validation changes were added; no pod scheduling, replica, affinity, or topology-aware controller code was modified.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes were added; the PR only changes validation annotations, CRD manifests, and YAML test fixtures.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds CRD validation and declarative YAML fixtures only; no new Ginkgo e2e tests, IPv4-only logic, or public internet connectivity were found.
No-Weak-Crypto	✅ Passed	Scanned all touched files; no MD5/SHA1/DES/RC4/ECB, crypto imports, or secret-comparison code. Changes are validation annotations and YAML tests only.
Container-Privileges	✅ Passed	Changed files are CRD/tests only; no privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or runAsRoot fields were found.
No-Sensitive-Data-In-Logs	✅ Passed	No added logging or print statements were found in the changed files; the PR only adds schema validation and test fixtures, not runtime logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-DevPreviewNoUpgrade.crd.yaml`:
- Around line 1096-1099: The validation rule near the failure-domain/vCenter
message currently permits configurations with failureDomains but no vcenters;
update it so vcenters is required whenever failureDomains is configured, while
preserving the check that every failure domain matches a vcenter.server entry.

In
`@payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-TechPreviewNoUpgrade.crd.yaml`:
- Around line 1096-1099: Update the CEL validation rule for failureDomains in
both
payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-TechPreviewNoUpgrade.crd.yaml:1096-1099
and
payload-manifests/crds/0000_10_config-operator_01_infrastructures-SelfManagedHA-CustomNoUpgrade.crd.yaml:1111-1114
so every configured failure domain requires vcenters to be present and include a
matching server; remove the !has(self.vcenters) short-circuit, then regenerate
the corresponding CRDs.

In
`@payload-manifests/crds/0000_10_config-operator_01_infrastructures-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml`:
- Around line 1111-1114: Update the failure-domain validation rule in both
listed SelfManagedHA CRD files at the specified ranges so vcenters is required
whenever failureDomains is present before matching servers; regenerate the
generated CRDs to apply the corrected rule consistently.

In
`@payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-CustomNoUpgrade.crd.yaml`:
- Around line 1403-1407: Update the failure-domain validation rule to reject
configurations where failureDomains is present without vcenters. Remove the
!has(self.vcenters) bypass while preserving validation that every failure domain
has a matching vCenter server.

In
`@payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-DevPreviewNoUpgrade.crd.yaml`:
- Around line 1388-1392: Update the CEL rule for the failureDomains/vcenters
validation in all four listed
CRDs—payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-DevPreviewNoUpgrade.crd.yaml:1388-1392,
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-TechPreviewNoUpgrade.crd.yaml:1388-1392,
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-CustomNoUpgrade.crd.yaml:1403-1407,
and
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml:1403-1407—so
failureDomains cannot bypass validation when vcenters is absent; remove the
!has(self.vcenters) short-circuit or explicitly require vcenters whenever
failureDomains is present, while preserving the matching-entry check.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ad3586cd-9c22-4c43-bedd-381ff9931a24

📥 Commits

Reviewing files that changed from the base of the PR and between 1e68ae5 and f9b8721.

⛔ Files ignored due to path filters (14)

config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Hypershift-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Hypershift-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Hypershift-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-SelfManagedHA-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
config/v1/zz_generated.featuregated-crd-manifests/infrastructures.config.openshift.io/VSphereMultiVCenterDay2.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Hypershift-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Hypershift-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Hypershift-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/VSphereMultiVCenterDay2.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (16)

CLAUDE.md
CLAUDE.md
config/v1/tests/infrastructures.config.openshift.io/VSphereMultiVCenterDay2.yaml
config/v1/types_infrastructure.go
payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_10_config-operator_01_infrastructures-Hypershift-TechPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_10_config-operator_01_infrastructures-SelfManagedHA-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_10_config-operator_01_infrastructures-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_10_config-operator_01_infrastructures-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Hypershift-TechPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml

jcpowermac · 2026-07-14T19:14:59Z

/verified by @jcpowermac via e2e testing

CSI storage in new failure domain should confirm vCenter removal blocked by existing xValidation, PV presence irrelevant (N-CSI-09) [real-vcenter, mutating, storage, p1]
/home/jcallen/Development/testing-day2-vcenter/test/e2e/csi_storage_test.go:455
  probing removal of vCenter vcenter-120.ci.ibmc.devcluster.openshift.com (hosts FD with PVs) via dry-run
  vCenter removal denied as expected: Infrastructure.config.openshift.io "cluster" is invalid: spec.platformSpec.vsphere: Invalid value: all failure domains must have a corresponding vCenter entry
  PV presence irrelevant — denial is based on FD reference to vCenter, not PV protection
  ...

https://github.com/jcpowermac/testing-day2-vcenter/blob/main/docs/tests/N-CSI-09.md

openshift-ci-robot · 2026-07-14T19:15:11Z

@jcpowermac: This PR has been marked as verified by @jcpowermac via e2e testing.

Details

In response to this:

/verified by @jcpowermac via e2e testing

CSI storage in new failure domain should confirm vCenter removal blocked by existing xValidation, PV presence irrelevant (N-CSI-09) [real-vcenter, mutating, storage, p1]
/home/jcallen/Development/testing-day2-vcenter/test/e2e/csi_storage_test.go:455
 probing removal of vCenter vcenter-120.ci.ibmc.devcluster.openshift.com (hosts FD with PVs) via dry-run
 vCenter removal denied as expected: Infrastructure.config.openshift.io "cluster" is invalid: spec.platformSpec.vsphere: Invalid value: all failure domains must have a corresponding vCenter entry
 PV presence irrelevant — denial is based on FD reference to vCenter, not PV protection
 ...

https://github.com/jcpowermac/testing-day2-vcenter/blob/main/docs/tests/N-CSI-09.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-07-23T16:28:55Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview
/test minor-e2e-upgrade-minor

vr4manta · 2026-07-23T16:29:15Z

/hold

JoelSpeed · 2026-07-24T11:57:55Z

/lgtm

openshift-merge-bot · 2026-07-24T11:58:09Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview
/test minor-e2e-upgrade-minor

openshift-ci · 2026-07-24T11:58:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vr4manta · 2026-07-24T17:28:25Z

/retest

JoelSpeed · 2026-07-26T21:37:43Z

/override-sticky ci/prow/verify-hypershift-integration

openshift-ci · 2026-07-26T21:37:49Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-hypershift-integration

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2026-07-26T21:38:23Z

/retest

JoelSpeed · 2026-07-27T11:43:16Z

/override ci/prow/e2e-azure
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-serial-2of2

I'm fairly confident that this vsphere only change isn't affecting these AWS and Azure jobs. There's no sign of broken CRDs in the E2E

openshift-ci · 2026-07-27T11:43:26Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-2of2, ci/prow/e2e-azure

Details

In response to this:

/override ci/prow/e2e-azure
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-serial-2of2

I'm fairly confident that this vsphere only change isn't affecting these AWS and Azure jobs. There's no sign of broken CRDs in the E2E

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vr4manta · 2026-07-27T12:39:35Z

/verified by @vr4manta

openshift-ci-robot · 2026-07-27T12:39:48Z

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vr4manta · 2026-07-27T12:41:39Z

/unhold

JoelSpeed · 2026-07-27T14:14:01Z

/override-sticky ci/prow/verify-hypershift-integration

openshift-ci · 2026-07-27T14:14:12Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-hypershift-integration

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-07-27T14:14:16Z

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2026

openshift-ci Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 14, 2026

openshift-ci Bot requested review from JoelSpeed and sinnykumari July 14, 2026 12:22

coderabbitai Bot reviewed Jul 14, 2026

View reviewed changes

vr4manta force-pushed the SPLAT-2827 branch from f9b8721 to ca4c0ef Compare July 14, 2026 13:09

openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2026

vr4manta force-pushed the SPLAT-2827 branch from ca4c0ef to d8d49e8 Compare July 14, 2026 14:00

openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 14, 2026

vr4manta force-pushed the SPLAT-2827 branch from d8d49e8 to 6c972d0 Compare July 14, 2026 14:05

openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2026

vr4manta force-pushed the SPLAT-2827 branch from 6c972d0 to c9e7558 Compare July 14, 2026 14:07

openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 14, 2026

vr4manta force-pushed the SPLAT-2827 branch from c9e7558 to e3ffc64 Compare July 14, 2026 14:13

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 14, 2026

saschagrunert reviewed Jul 15, 2026

View reviewed changes

Comment thread config/v1/types_infrastructure.go

vr4manta force-pushed the SPLAT-2827 branch from e3ffc64 to 61bc623 Compare July 15, 2026 12:01

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jul 15, 2026

openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2026

openshift-ci Bot assigned JoelSpeed Jul 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 23, 2026

vr4manta force-pushed the SPLAT-2827 branch from 7037cea to 00d6911 Compare July 24, 2026 11:38

vr4manta added 2 commits July 24, 2026 07:53

Added vSphere failure domain to vcenter check

db1ed9c

Added vSphere failure domain to vcenter ratcheting tests

5c06b67

vr4manta force-pushed the SPLAT-2827 branch from 00d6911 to 5c06b67 Compare July 24, 2026 11:53

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 27, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026

openshift-merge-bot Bot merged commit 967cc4c into openshift:master Jul 27, 2026
31 checks passed

Uh oh!

Conversation

vr4manta commented Jul 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-merge-bot Bot commented Jul 14, 2026

Uh oh!

openshift-ci-robot commented Jul 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-ci Bot commented Jul 14, 2026

Uh oh!

coderabbitai Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcpowermac commented Jul 14, 2026

Uh oh!

openshift-ci-robot commented Jul 14, 2026

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

vr4manta commented Jul 23, 2026

Uh oh!

JoelSpeed commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

vr4manta commented Jul 24, 2026

Uh oh!

JoelSpeed commented Jul 26, 2026

Uh oh!

openshift-ci Bot commented Jul 26, 2026

Uh oh!

JoelSpeed commented Jul 26, 2026

Uh oh!

JoelSpeed commented Jul 27, 2026

Uh oh!

openshift-ci Bot commented Jul 27, 2026

Uh oh!

vr4manta commented Jul 27, 2026

Uh oh!

openshift-ci-robot commented Jul 27, 2026

Uh oh!

vr4manta commented Jul 27, 2026

Uh oh!

JoelSpeed commented Jul 27, 2026

Uh oh!

openshift-ci Bot commented Jul 27, 2026

Uh oh!

openshift-ci Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vr4manta commented Jul 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jul 14, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading