OCPBUGS-49351: Added vSphere check for max networks - #1327
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@vr4manta: This pull request references Jira Issue OCPBUGS-49351, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest |
|
/assign @JoelSpeed |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
When did this API ship as stable? |
I believe it was back in the 4.13 time frame. |
|
So given a lack of previous validation, in theory there could be any number of networks in this list? Is it possible to create a ratcheting validation where we would allow existing configurations to continue to work? Given that would mean machinesets with invalid values, leading to then creating new machines failing, I'm not sure how possible that would be 🤔 What happens today if a MachineSet tries to create a VM with more than 10 networks listed? |
|
I am pretty sure if any customer tried to add more than 10, the vSphere would fail to create the machine. According to broadcom documentation, 10 is the max number of NICs allowed per VM. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label acknowledge-critical-fixes-only |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
@vr4manta: Jira Issue OCPBUGS-49351: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-49351 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-operator |
5 participants
OCPBUGS-49351
Changes