Skip to content

optionally enable mdns service in firewalld - #1341

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
zenghui-shi:mdns-doc-optional
Feb 9, 2023
Merged

optionally enable mdns service in firewalld#1341
openshift-merge-robot merged 1 commit into
openshift:mainfrom
zenghui-shi:mdns-doc-optional

Conversation

@zenghui-shi

@zenghui-shi zenghui-shi commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related-Issue: https://issues.redhat.com/browse/OCPBUGS-6862

Signed-off-by: Zenghui Shi zshi@redhat.com

@openshift-ci
openshift-ci Bot requested review from ggiguash and sallyom February 8, 2023 08:37
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@zenghui-shi

zenghui-shi commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

/retest

fzdarsky
fzdarsky reviewed Feb 8, 2023
View reviewed changes
Comment thread docs/howto_firewall.md Outdated
@zenghui-shi
optionally enable mdns service in firewalld
a5da92b 
Signed-off-by: Zenghui Shi <zshi@redhat.com>
@zenghui-shi

zenghui-shi commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@ggiguash

ggiguash commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@zshi-redhat, please add a JIRA issue for this PR and unhold it to merge.
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@ggiguash

ggiguash commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci

openshift-ci Bot commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ggiguash,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zenghui-shi

zenghui-shi commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@openshift-ci

openshift-ci Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

@zshi-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
openshift-merge-robot merged commit f4dd4a8 into openshift:main Feb 9, 2023
This was referenced Jul 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash
@sallyom sallyom Awaiting requested review from sallyom
1 more reviewer
@fzdarsky fzdarsky fzdarsky left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zenghui-shi @ggiguash @fzdarsky @openshift-merge-robot