Skip to content

NO-ISSUE: Optional pull-secret for extracting lvms bundle - #1345

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:rebase/lvms/optional-pull-secret
Feb 9, 2023
Merged

NO-ISSUE: Optional pull-secret for extracting lvms bundle#1345
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:rebase/lvms/optional-pull-secret

Conversation

@pmtk

@pmtk pmtk commented Feb 9, 2023

Copy link
Copy Markdown
Member

Fixes builds in ART environment

@openshift-ci-robot

openshift-ci-robot commented Feb 9, 2023

Copy link
Copy Markdown

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Fixes builds in ART environment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2023
@openshift-ci
openshift-ci Bot requested review from copejon and dhellmann February 9, 2023 10:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@ggiguash

ggiguash commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-ci

openshift-ci Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vfreex

vfreex commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci-robot

openshift-ci-robot commented Feb 9, 2023

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 656ce94 and 2 for PR HEAD cc3c18c in total

@ggiguash

ggiguash commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
openshift-merge-robot merged commit 142a3a6 into openshift:main Feb 9, 2023
@pmtk
pmtk deleted the rebase/lvms/optional-pull-secret branch February 14, 2023 09:31
This was referenced Jul 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon
@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmtk @openshift-ci-robot @ggiguash @vfreex @openshift-merge-robot