Skip to content

USHIFT-1270: The ISO image version should be deduced from the microshift RPM - #1830

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
ggiguash:image_builder_starter
May 24, 2023
Merged

USHIFT-1270: The ISO image version should be deduced from the microshift RPM#1830
openshift-merge-robot merged 1 commit into
openshift:mainfrom
ggiguash:image_builder_starter

Conversation

@ggiguash

@ggiguash ggiguash commented May 23, 2023

Copy link
Copy Markdown
Contributor

Tested using the following sequence

BUILD_ARCH=$(uname -m)
OCP_REPO_NAME="rhocp-4.13-for-rhel-9-${BUILD_ARCH}-rpms"
reposync -n -a "${BUILD_ARCH}" -a noarch --download-path ~/openshift-local --repo="${OCP_REPO_NAME}"
find ~/openshift-local -type f -not -name microshift\* -exec rm -f {} \;

~/microshift/scripts/image-builder/build.sh -microshift_rpms ~/openshift-local -pull_secret_file ~/.pull-secret.json

Closes USHIFT-1270

@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2023
@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
openshift-ci Bot requested review from copejon and pmtk May 23, 2023 07:56
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Tested using the following sequence

OCP_REPO_NAME="rhocp-4.13-for-rhel-9-$(uname -m)-rpms"
BUILD_ARCH=$(uname -m)
reposync -n -a "${BUILD_ARCH}" -a noarch --download-path ~/openshift-local --repo="${OCP_REPO_NAME}"

~/microshift/scripts/image-builder/build.sh -microshift_rpms ~/openshift-local -pull_secret_file ~/.pull-secret.json`

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Tested using the following sequence

BUILD_ARCH=$(uname -m)
OCP_REPO_NAME="rhocp-4.13-for-rhel-9-${BUILD_ARCH}-rpms"
reposync -n -a "${BUILD_ARCH}" -a noarch --download-path ~/openshift-local --repo="${OCP_REPO_NAME}"

~/microshift/scripts/image-builder/build.sh -microshift_rpms ~/openshift-local -pull_secret_file ~/.pull-secret.json`

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Tested using the following sequence

BUILD_ARCH=$(uname -m)
OCP_REPO_NAME="rhocp-4.13-for-rhel-9-${BUILD_ARCH}-rpms"
reposync -n -a "${BUILD_ARCH}" -a noarch --download-path ~/openshift-local --repo="${OCP_REPO_NAME}"
find ~/openshift-local -type f -not -name microshift\* -exec rm -f {} \;

~/microshift/scripts/image-builder/build.sh -microshift_rpms ~/openshift-local -pull_secret_file ~/.pull-secret.json`

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

openshift-ci-robot commented May 23, 2023

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-1270 which is a valid jira issue.

Details

In response to this:

Tested using the following sequence

BUILD_ARCH=$(uname -m)
OCP_REPO_NAME="rhocp-4.13-for-rhel-9-${BUILD_ARCH}-rpms"
reposync -n -a "${BUILD_ARCH}" -a noarch --download-path ~/openshift-local --repo="${OCP_REPO_NAME}"
find ~/openshift-local -type f -not -name microshift\* -exec rm -f {} \;

~/microshift/scripts/image-builder/build.sh -microshift_rpms ~/openshift-local -pull_secret_file ~/.pull-secret.json

Closes USHIFT-1270

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
ggiguash force-pushed the image_builder_starter branch from cfe5266 to 021e9b1 Compare May 23, 2023 08:13
@pmtk

pmtk commented May 24, 2023

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci

openshift-ci Bot commented May 24, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 038da07 and 2 for PR HEAD 021e9b1 in total

@ggiguash

Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-openshift-conformance-reduced-arm
/override ci/prow/microshift-e2e-arm
/override ci/prow/e2e-openshift-conformance-reduced

@openshift-ci

openshift-ci Bot commented May 24, 2023

Copy link
Copy Markdown
Contributor

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-openshift-conformance-reduced, ci/prow/e2e-openshift-conformance-reduced-arm, ci/prow/microshift-e2e-arm

Details

In response to this:

/override ci/prow/e2e-openshift-conformance-reduced-arm
/override ci/prow/microshift-e2e-arm
/override ci/prow/e2e-openshift-conformance-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
openshift-merge-robot merged commit d8abfc2 into openshift:main May 24, 2023
@openshift-ci

openshift-ci Bot commented May 24, 2023

Copy link
Copy Markdown
Contributor

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants