Skip to content

USHIFT-2924: Add support for templates in bootc image and container files - #3320

Merged
openshift-merge-bot[bot] merged 7 commits into
openshift:mainfrom
ggiguash:bootc_gomplate
May 9, 2024
Merged

USHIFT-2924: Add support for templates in bootc image and container files#3320
openshift-merge-bot[bot] merged 7 commits into
openshift:mainfrom
ggiguash:bootc_gomplate

Conversation

@ggiguash

@ggiguash ggiguash commented May 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

In addition, optimized the container files by:

  • Merging multiple RUN commands into one to avoid linter errors
  • Switching to using fast-datapath and rhocp repos in rhel images

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 4, 2024
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2024
@openshift-ci-robot

openshift-ci-robot commented May 4, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 4, 2024

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test ?

@openshift-ci

openshift-ci Bot commented May 4, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2024
@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test verify

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@ggiguash

ggiguash commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

/test verify
/test metal-bootc-test

@openshift-ci-robot

openshift-ci-robot commented May 4, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

In addition, optimized the container files by:

  • Merging multiple RUN commands into one
  • Switching to using fast-datapath and rhocp repos in rhel images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented May 4, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

In addition, optimized the container files by:

  • Merging multiple RUN commands into one to avoid linter errors
  • Switching to using fast-datapath and rhocp repos in rhel images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
ggiguash marked this pull request as ready for review May 4, 2024 09:41
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2024
@openshift-ci
openshift-ci Bot requested review from pacevedom and pmtk May 4, 2024 09:41
@ggiguash

ggiguash commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

/assign @pacevedom @pmtk

pmtk
pmtk reviewed May 7, 2024
View reviewed changes
Comment thread test/bin/pyutils/build_bootc_images.py Outdated
Comment thread test/bin/pyutils/build_bootc_images.py
Comment thread test/image-blueprints/layer5-bootc/group1/rhel94-bootc-source.containerfile Outdated
Comment thread test/bin/pyutils/build_bootc_images.py
copejon
copejon reviewed May 7, 2024
View reviewed changes
Comment thread test/image-blueprints/layer5-bootc/group2/rhel94-bootc-source-optionals.containerfile Outdated
@ggiguash
ggiguash marked this pull request as draft May 8, 2024 05:54
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@ggiguash ggiguash changed the title USHIFT-2924: Add support for gomplate in bootc image and container files USHIFT-2924: Add support for templates in bootc image and container files May 8, 2024
@ggiguash
ggiguash marked this pull request as ready for review May 8, 2024 15:59
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@openshift-ci
openshift-ci Bot requested review from jerpeter1 and jogeo May 8, 2024 15:59
@copejon

copejon commented May 8, 2024

Copy link
Copy Markdown
Contributor

These changes LGTM. Will wait for @pmtk to chime in before labeling

@ggiguash

ggiguash commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

Failures not related to the PR changes - saving CI cycles.
/override ci/prow/metal-periodic-test-arm

@openshift-ci

openshift-ci Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test-arm

Details

In response to this:

Failures not related to the PR changes - saving CI cycles.
/override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
ggiguash marked this pull request as draft May 9, 2024 10:45
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@ggiguash
ggiguash marked this pull request as ready for review May 9, 2024 12:08
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@pmtk

pmtk commented May 9, 2024

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci

openshift-ci Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented May 9, 2024

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 2468544 and 2 for PR HEAD babb466 in total

@openshift-ci

openshift-ci Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4caea4b into openshift:main May 9, 2024
@ggiguash
ggiguash deleted the bootc_gomplate branch May 10, 2024 05:31
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmtk pmtk pmtk left review comments
@copejon copejon copejon left review comments
@pacevedom pacevedom Awaiting requested review from pacevedom
@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1
@jogeo jogeo Awaiting requested review from jogeo

Assignees

@pmtk pmtk

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggiguash @openshift-ci-robot @copejon @pmtk @pacevedom