Skip to content

OCPBUGS-38848: 4.18 rebase with kubelet.yaml fix - #3806

Closed
pmtk wants to merge 12 commits into
openshift:mainfrom
pmtk:rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20
Closed

OCPBUGS-38848: 4.18 rebase with kubelet.yaml fix#3806
pmtk wants to merge 12 commits into
openshift:mainfrom
pmtk:rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20

Conversation

@pmtk

@pmtk pmtk commented Aug 22, 2024

Copy link
Copy Markdown
Member

Original rebase PR: #3804

@pmtk pmtk mentioned this pull request Aug 22, 2024
Closed
@openshift-ci
openshift-ci Bot requested review from jogeo and pacevedom August 22, 2024 13:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@pmtk pmtk changed the title 4.18 rebase with kubelet.yaml fix OCPBUGS-38848: 4.18 rebase with kubelet.yaml fix Aug 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 22, 2024
@openshift-ci-robot

openshift-ci-robot commented Aug 22, 2024

Copy link
Copy Markdown

@pmtk: This pull request references Jira Issue OCPBUGS-38848, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Original rebase PR: #3804

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash

ggiguash commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@openshift-ci

openshift-ci Bot commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@openshift-ci

openshift-ci Bot commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@copejon

copejon commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

/retest

@ggiguash

ggiguash commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

/retest-required

2 similar comments
@ggiguash

ggiguash commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

/retest-required

@ggiguash

ggiguash commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

/retest-required

@pmtk
pmtk force-pushed the rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20 branch from b17ac5b to d91805e Compare August 26, 2024 09:00
@pmtk
pmtk force-pushed the rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20 branch 2 times, most recently from 3344a8f to 2672c49 Compare August 26, 2024 12:51
@pmtk

pmtk commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@pmtk

pmtk commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

/retest

@copejon

copejon commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

CI team has moved builds to another farm while they sort out the bug. Tests shouldn't encounter the secret injection error any more

/retest

@pmtk

pmtk commented Aug 28, 2024

Copy link
Copy Markdown
Member Author

/retest

@pmtk
pmtk force-pushed the rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20 branch 3 times, most recently from 68f41ef to f98203f Compare August 28, 2024 14:09
@pacevedom

pacevedom commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

/retest

pmtk added 2 commits August 29, 2024 10:00
@pmtk
update test/
e8c4d8c
@pmtk
bump cri-tools, leave cri-o
fb99dc3 
Bumping cri-tools but not cri-o because at the time of this commit, the
RHOCP mirror had them misaligned.
@pmtk
pmtk force-pushed the rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20 branch from f98203f to fb99dc3 Compare August 29, 2024 08:00
@openshift-ci

openshift-ci Bot commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/metal-bootc-test fb99dc3 link true /test metal-bootc-test
ci/prow/metal-bootc-periodic-test fb99dc3 link true /test metal-bootc-periodic-test
ci/prow/test-rebase fb99dc3 link false /test test-rebase
ci/prow/metal-bootc-test-arm fb99dc3 link true /test metal-bootc-test-arm
ci/prow/metal-bootc-periodic-test-arm fb99dc3 link true /test metal-bootc-periodic-test-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk

pmtk commented Aug 29, 2024

Copy link
Copy Markdown
Member Author

See #3829 instead with newer release images
/close

@openshift-ci

openshift-ci Bot commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

@pmtk: Closed this PR.

Details

In response to this:

See #3829 instead with newer release images
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot closed this Aug 29, 2024
@openshift-ci-robot

openshift-ci-robot commented Aug 29, 2024

Copy link
Copy Markdown

@pmtk: This pull request references Jira Issue OCPBUGS-38848. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Original rebase PR: #3804

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
pmtk deleted the rebase-fix-kubelet-rebase/main-4.18.0-0.nightly-2024-08-19-002129_amd64-2024-08-19_arm64-2024-08-20 branch October 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo
@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmtk @openshift-ci-robot @ggiguash @copejon @pacevedom