Skip to content

ocp components simplify,clarify names - #496

Merged
fzdarsky merged 1 commit into
openshift:mainfrom
sallyom:simplify-names-ocp-controllers
Dec 15, 2021
Merged

ocp components simplify,clarify names#496
fzdarsky merged 1 commit into
openshift:mainfrom
sallyom:simplify-names-ocp-controllers

Conversation

@sallyom

@sallyom sallyom commented Dec 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Sally O'Malley somalley@redhat.com

PR to update names of PrepJob, APIComponents service managers, files, and functions to describe what they do:

NewOpenShiftPrepJob  ->  NewOpenShiftCRDManager
NewOpenShiftAPIComponents  ->  NewOpenShiftDefaultSCCManager

move openshift-controller-manager namespace creation to the StartOCM configure function

Closes #

@sallyom
sallyom force-pushed the simplify-names-ocp-controllers branch from fda1edc to a68740f Compare December 12, 2021 15:37
@sallyom sallyom mentioned this pull request Dec 12, 2021
Closed
husky-parul
husky-parul approved these changes Dec 13, 2021
View reviewed changes

@husky-parul husky-parul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread pkg/controllers/openshift-controller-manager.go Outdated

@husky-parul husky-parul Dec 13, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logrus.Warningf("Failed to apply openshift namespaces %v", err)

@sallyom sallyom Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking thru the code, the other examples show lower case, i wasn't sure so i went w/ that

@husky-parul husky-parul Dec 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that is why I didn't request review changes, the klog PR will change all the lower case to upper case anyways as per https://pkg.go.dev/k8s.io/klog#pkg-overview

Comment thread pkg/components/controllers.go Outdated

@husky-parul husky-parul Dec 13, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logrus.Warningf("Failed to apply apps %v: %v", apps, err)

Comment thread pkg/controllers/openshift-apiserver.go Outdated

@husky-parul husky-parul Dec 13, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logrus.Infof("Starting openshift-apiserver %s, args: %v", cfg.NodeIP, args)

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2021
@sallyom

sallyom commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

/test all

@mangelajo

mangelajo commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

/lgtm

I'd change the case as suggested by Parul.

@sallyom
ocp components simplify,clarify names
3bf1a00 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom
sallyom force-pushed the simplify-names-ocp-controllers branch from a68740f to 3bf1a00 Compare December 15, 2021 15:14
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@husky-parul

husky-parul commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

/approved

@openshift-ci

openshift-ci Bot commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

@sallyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-scheduling 3bf1a00 link false /test e2e-openshift-conformance-sig-scheduling
ci/prow/e2e-reboot 3bf1a00 link false /test e2e-reboot
ci/prow/e2e-openshift-conformance-sig-cli 3bf1a00 link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-api-machinery 3bf1a00 link false /test e2e-openshift-conformance-sig-api-machinery
ci/prow/e2e-openshift-conformance-sig-auth 3bf1a00 link false /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-rpm-install 3bf1a00 link false /test e2e-rpm-install
ci/prow/e2e-openshift-conformance-sig-instrumentation 3bf1a00 link false /test e2e-openshift-conformance-sig-instrumentation
ci/prow/e2e-openshift-conformance-sig-storage 3bf1a00 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-arch 3bf1a00 link false /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-openshift-conformance-sig-node 3bf1a00 link false /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-apps 3bf1a00 link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-network 3bf1a00 link false /test e2e-openshift-conformance-sig-network

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fzdarsky

fzdarsky commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@openshift-ci

openshift-ci Bot commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky, husky-parul, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [fzdarsky,husky-parul,mangelajo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fzdarsky
fzdarsky merged commit b721511 into openshift:main Dec 15, 2021
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mangelajo mangelajo Awaiting requested review from mangelajo
1 more reviewer
@husky-parul husky-parul husky-parul approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mangelajo mangelajo

@fzdarsky fzdarsky

@husky-parul husky-parul

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sallyom @mangelajo @husky-parul @fzdarsky