Skip to content

USHIFT-6175: Ginkgo releases tests are failing in CI - #5518

Merged
openshift-merge-bot[bot] merged 20 commits into
openshift:mainfrom
agullon:USHIFT-6175
Oct 1, 2025
Merged

USHIFT-6175: Ginkgo releases tests are failing in CI#5518
openshift-merge-bot[bot] merged 20 commits into
openshift:mainfrom
agullon:USHIFT-6175

Conversation

@agullon

@agullon agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor
  • Filter out Ginkgo disruptive tests adding ~Disruptive filter
  • Add global timeout for all the Ginkgo tests suite
  • Use 'does_commit_exist()' instead of 'does_image_exist()' in rpm-ostree
  • Use make all instead of make build command to update ginkgo repo to the latest version
  • Clone specific commit from openshift-test-private repo to secure successful execution of test
    • This commit id must be updated every few days/weeks to be in sync with latest changes
    • I'll propose a follow up change to automate or improve this proccess

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 24, 2025

Copy link
Copy Markdown

@agullon: This pull request references USHIFT-6175 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 24, 2025

Copy link
Copy Markdown

@agullon: This pull request references USHIFT-6175 which is a valid jira issue.

Details

In response to this:

  • Filter out Ginkgo disruptive tests adding ~Disruptive filter
  • Add global timeout for all the Ginkgo tests suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

Comment thread test/bin/scenario.sh Outdated
fi

# Run the tests and capture output with 10m timeout for every test case
if ! "${timeout_ginkgo}" run --timeout 10m --junit-dir="${test_results_dir}" -f "${case_selected}" 2>&1 | tee "${test_results_dir}/test-output.log"; then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not 10m too less ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for every test case, I think is more than enough. For example, on Jenkins, for release-4.20 branch 59 tests take less than 23 mins to run.

Comment thread test/bin/scenario.sh
@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/restest

@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@kasturinarra

Copy link
Copy Markdown
Contributor

/lgtm
From the code perspective.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@agullon

agullon commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
Comment thread test/bin/scenario.sh
Comment thread test/scenarios-bootc/releases/el96-lrel@ginkgo-tests.sh
@pacevedom

Copy link
Copy Markdown
Contributor

/test e2e-aws-tests-arm

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/restes-required

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/restest-required

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest

3 similar comments
@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci-robot

openshift-ci-robot commented Sep 30, 2025

Copy link
Copy Markdown

@agullon: This pull request references USHIFT-6175 which is a valid jira issue.

Details

In response to this:

  • Filter out Ginkgo disruptive tests adding ~Disruptive filter
  • Add global timeout for all the Ginkgo tests suite
  • Use 'does_commit_exist()' instead of 'does_image_exist()' in rpm-ostree
  • Use make all instead of make build command to update ginkgo repo to the latest version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kasturinarra

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@agullon

agullon commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-release-arm

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@agullon

agullon commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@agullon

agullon commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-release

@openshift-ci-robot

openshift-ci-robot commented Oct 1, 2025

Copy link
Copy Markdown

@agullon: This pull request references USHIFT-6175 which is a valid jira issue.

Details

In response to this:

  • Filter out Ginkgo disruptive tests adding ~Disruptive filter
  • Add global timeout for all the Ginkgo tests suite
  • Use 'does_commit_exist()' instead of 'does_image_exist()' in rpm-ostree
  • Use make all instead of make build command to update ginkgo repo to the latest version
  • Clone specific commit from openshift-test-private repo to secure successful execution of test
    • This commit id must be updated every few days/weeks to be in sync with latest changes
    • I'll propose a follow up change to automate or improve this proccess

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kasturinarra

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [agullon,kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon

agullon commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

/verify by CI

@agullon

agullon commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 1, 2025
@openshift-ci-robot

Copy link
Copy Markdown

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 527f77d into openshift:main Oct 1, 2025
17 checks passed
agullon pushed a commit to agullon/microshift that referenced this pull request Oct 2, 2025
USHIFT-6175: Ginkgo releases tests are failing in CI
(cherry picked from commit 527f77d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants