Pin setuptools below 82 to fix unit test discovery - #431
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 24, 2026
Merged
Conversation
setuptools 82 removed pkg_resources, which keystonemiddleware still imports during test discovery. Pin setuptools in test requirements and force-reinstall it in tox before running tests. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: Ia2156afc279e9cf5f8acb9853c5bff353818c094
|
@MahnoorAsghar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, MahnoorAsghar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit Jun 24, 2026
6f976ba
into
openshift:release-4.13
4 checks passed
rh-soboh
added a commit
to rh-soboh/openstack-ironic
that referenced
this pull request
Jul 29, 2026
setuptools 82 removed pkg_resources, which flake8-import-order still imports. Same approach as: - openshift#432 (4.12) - openshift#431 (4.13) - openshift#430 (4.14) - openshift#428 (4.15)
rh-soboh
added a commit
to rh-soboh/openstack-ironic
that referenced
this pull request
Jul 29, 2026
setuptools 82 removed pkg_resources, which keystonemiddleware and flake8-import-order still import. Same approach as: - openshift#432 (4.12) - openshift#431 (4.13) - openshift#430 (4.14) - openshift#428 (4.15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 82 removed pkg_resources, which keystonemiddleware still imports during test discovery. Pin setuptools in test requirements and force-reinstall it in tox before running tests.