Skip to content

OCPBUGS-105861: block vendor.send_raw step exposure CVE-2026-54423(release-4.21) - #477

Open
amitesh1201 wants to merge 2 commits into
openshift:release-4.21from
amitesh1201:fix/CVE-2026-54423-4.21
Open

OCPBUGS-105861: block vendor.send_raw step exposure CVE-2026-54423(release-4.21)#477
amitesh1201 wants to merge 2 commits into
openshift:release-4.21from
amitesh1201:fix/CVE-2026-54423-4.21

Conversation

@amitesh1201

Copy link
Copy Markdown

Summary

  • Removes the @base.deploy_step, @base.clean_step, and @base.service_step decorators from VendorPassthru.send_raw in ipmitool.py, preventing send_raw from being invoked through deploy/clean/service workflows.
  • Removes _send_raw_step_args dictionary that is no longer needed.
  • Removes two tests (test_send_raw_bytes_is_in_step_list and test_send_raw_bytes_from_clean_step) that assert the now-removed step registration behavior.
  • The @base.passthru HTTP API is preserved and continues to enforce its own RBAC.

Background

The upstream fix (openstack/ironic@7bbe5a2) adds vendor.send_raw to the disallow_*_steps config blocklist defaults, but that config infrastructure does not exist on this branch. This alternative fix removes the step registration entirely to achieve the same security outcome.

Tracker

Made with Cursor

amitesh1201 and others added 2 commits August 13, 2026 20:16
CVE-2026-54423)

Remove the @base.deploy_step, @base.clean_step, and @base.service_step
decorators from VendorPassthru.send_raw in ipmitool.py. The upstream
fix adds vendor.send_raw to the disallow_*_steps config blocklist, but
that infrastructure does not exist on this branch.

This alternative fix removes the step registration entirely, preventing
send_raw from being invoked through deploy/clean/service workflows.
The VendorPassthru HTTP passthru API (@base.passthru) is preserved and
continues to enforce its own RBAC.

Signed-off-by: Amit Yadav <ayadav@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…istration (CVE-2026-54423)

Remove test_send_raw_bytes_is_in_step_list and
test_send_raw_bytes_from_clean_step which assert that send_raw is
registered as a deploy/clean step. These tests validate the exact
behavior that the previous commit removes to fix CVE-2026-54423.

Signed-off-by: Amit Yadav <ayadav@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amitesh1201: This pull request references Jira Issue OCPBUGS-105861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-105863 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Removes the @base.deploy_step, @base.clean_step, and @base.service_step decorators from VendorPassthru.send_raw in ipmitool.py, preventing send_raw from being invoked through deploy/clean/service workflows.
  • Removes _send_raw_step_args dictionary that is no longer needed.
  • Removes two tests (test_send_raw_bytes_is_in_step_list and test_send_raw_bytes_from_clean_step) that assert the now-removed step registration behavior.
  • The @base.passthru HTTP API is preserved and continues to enforce its own RBAC.

Background

The upstream fix (openstack/ironic@7bbe5a2) adds vendor.send_raw to the disallow_*_steps config blocklist defaults, but that config infrastructure does not exist on this branch. This alternative fix removes the step registration entirely to achieve the same security outcome.

Tracker

  • OCPBUGS-105861
  • CVE: CVE-2026-54423
  • Advisory: OSSA-2026-025

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 13, 2026
@openshift-ci
openshift-ci Bot requested review from dtantsur and zaneb August 13, 2026 14:47
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown

@amitesh1201: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@elfosardo

Copy link
Copy Markdown

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitesh1201, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2026
@amitesh1201

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@amitesh1201: This pull request references Jira Issue OCPBUGS-105861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-105863 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prdhamdh

Copy link
Copy Markdown

/verified by CI test results

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@prdhamdh: This PR has been marked as verified by CI test results.

Details

In response to this:

/verified by CI test results

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants