OCPBUGS-105861: block vendor.send_raw step exposure CVE-2026-54423(release-4.21) - #477
OCPBUGS-105861: block vendor.send_raw step exposure CVE-2026-54423(release-4.21)#477amitesh1201 wants to merge 2 commits into
Conversation
CVE-2026-54423) Remove the @base.deploy_step, @base.clean_step, and @base.service_step decorators from VendorPassthru.send_raw in ipmitool.py. The upstream fix adds vendor.send_raw to the disallow_*_steps config blocklist, but that infrastructure does not exist on this branch. This alternative fix removes the step registration entirely, preventing send_raw from being invoked through deploy/clean/service workflows. The VendorPassthru HTTP passthru API (@base.passthru) is preserved and continues to enforce its own RBAC. Signed-off-by: Amit Yadav <ayadav@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…istration (CVE-2026-54423) Remove test_send_raw_bytes_is_in_step_list and test_send_raw_bytes_from_clean_step which assert that send_raw is registered as a deploy/clean step. These tests validate the exact behavior that the previous commit removes to fix CVE-2026-54423. Signed-off-by: Amit Yadav <ayadav@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
@amitesh1201: This pull request references Jira Issue OCPBUGS-105861, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amitesh1201: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitesh1201, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@amitesh1201: This pull request references Jira Issue OCPBUGS-105861, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI test results |
|
@prdhamdh: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
@base.deploy_step,@base.clean_step, and@base.service_stepdecorators fromVendorPassthru.send_rawinipmitool.py, preventingsend_rawfrom being invoked through deploy/clean/service workflows._send_raw_step_argsdictionary that is no longer needed.test_send_raw_bytes_is_in_step_listandtest_send_raw_bytes_from_clean_step) that assert the now-removed step registration behavior.@base.passthruHTTP API is preserved and continues to enforce its own RBAC.Background
The upstream fix (openstack/ironic@7bbe5a2) adds
vendor.send_rawto thedisallow_*_stepsconfig blocklist defaults, but that config infrastructure does not exist on this branch. This alternative fix removes the step registration entirely to achieve the same security outcome.Tracker
Made with Cursor