Skip to content

OCPQE-30425: Add metal SNO IPv6 http-proxy jobs for 4.18-5.0 - #83261

Open
snaoum-lang wants to merge 9 commits into
openshift:mainfrom
snaoum-lang:ocpqe-30425-metal-sno-ipv6-proxy
Open

OCPQE-30425: Add metal SNO IPv6 http-proxy jobs for 4.18-5.0#83261
snaoum-lang wants to merge 9 commits into
openshift:mainfrom
snaoum-lang:ocpqe-30425-metal-sno-ipv6-proxy

Conversation

@snaoum-lang

@snaoum-lang snaoum-lang commented Aug 11, 2026

Copy link
Copy Markdown

Summary

  • Add new step-registry workflow baremetal-lab-sno-ipv6-static for SNO BIP + IPv6 single-stack + cluster-wide HTTP proxy on RDU2 baremetal lab
  • Add new conf chain baremetal-lab-sno-ipv6-static-conf (uses baremetal-lab-upi-conf-grub2-ipv6-static instead of IPv4 grub2 step)
  • Add periodic jobs metal-sno-ipv6-http-proxy-* for OCP 4.18–5.0 (amd64 + arm64), reusing one workflow without per-version duplication

Related

Test plan

  • make update completed
  • Rehearse at least one amd64 job (e.g. 4.22 metal-sno-ipv6-http-proxy-f7)
  • Acceptance: cluster deploy/install succeeds (e2e failures are not a blocker per QE)

Summary by CodeRabbit

Adds IPv6 single-stack and cluster-wide HTTP proxy coverage for RDU2 bare-metal SNO clusters.

  • Adds the baremetal-lab-sno-ipv6-static workflow and configuration chain.
  • Configures provisioning, IPv6 networking, BIP, proxy, storage, telemetry, and teardown steps.
  • Generates noProxy entries from cluster networks, service networks, cluster domain, and API endpoints.
  • Uses bootstrap.ign for SNO bootstrap-in-place deployments.
  • Adds scheduled amd64 and arm64 jobs for OCP 4.18 through 5.0.
  • Adds OWNERS and metadata files for the workflow and configuration chain.

dd baremetal-lab-sno-ipv6-static workflow/chain and amd64/arm64
periodics so SNO BIP with IPv6 single-stack and cluster-wide proxy
is covered without changing existing SNO jobs.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@snaoum-lang: This pull request references OCPQE-30425 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add new step-registry workflow baremetal-lab-sno-ipv6-static for SNO BIP + IPv6 single-stack + cluster-wide HTTP proxy on RDU2 baremetal lab
  • Add new conf chain baremetal-lab-sno-ipv6-static-conf (uses baremetal-lab-upi-conf-grub2-ipv6-static instead of IPv4 grub2 step)
  • Add periodic jobs metal-sno-ipv6-http-proxy-* for OCP 4.18–5.0 (amd64 + arm64), reusing one workflow without per-version duplication

Related

Test plan

  • make update completed
  • Rehearse at least one amd64 job (e.g. 4.22 metal-sno-ipv6-http-proxy-f7)
  • Acceptance: cluster deploy/install succeeds (e2e failures are not a blocker per QE)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Added an IPv6 static bare-metal SNO workflow, its provisioning chain, proxy and bootstrap configuration, ownership metadata, and scheduled amd64 and arm64 HTTP proxy test jobs for releases 4.18 through 5.0.

Changes

IPv6 static SNO coverage

Layer / File(s) Summary
Proxy and bootstrap configuration
ci-operator/step-registry/ipi/conf/proxy/ipi-conf-proxy-commands.sh, ci-operator/step-registry/baremetal/lab/upi/conf/grub2/ipv6/static/*
Builds NO_PROXY from network and cluster settings. Adds it to generated proxy configurations. Selects bootstrap.ign for bootstrap-in-place deployments.
IPv6 static SNO configuration chain
ci-operator/step-registry/baremetal/lab/sno/ipv6/static/conf/*, ci-operator/step-registry/baremetal/lab/sno/ipv6/*/OWNERS
Adds the ordered IPv6 static bare-metal SNO provisioning chain, metadata, documentation, and ownership links.
IPv6 static SNO workflow
ci-operator/step-registry/baremetal/lab/sno/ipv6/static/baremetal-lab-sno-ipv6-static-workflow.*, ci-operator/step-registry/baremetal/lab/sno/ipv6/static/OWNERS
Adds the IPv6-only SNO workflow with proxy settings, lifecycle steps, result reporting, metadata, and ownership links.
Scheduled release test jobs
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-*.yaml
Adds scheduled amd64 and arm64 bare-metal SNO HTTP proxy jobs for releases 4.18 through 5.0.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseSchedule
  participant SNOWorkflow
  participant SNOConfigChain
  participant ProxyConfig
  ReleaseSchedule->>SNOWorkflow: Start scheduled IPv6 HTTP proxy test
  SNOWorkflow->>SNOConfigChain: Run IPv6 static SNO provisioning
  SNOConfigChain->>ProxyConfig: Generate proxy and NO_PROXY settings
  ProxyConfig-->>SNOConfigChain: Return generated proxy configuration
  SNOConfigChain-->>SNOWorkflow: Provide configured SNO environment
  SNOWorkflow-->>ReleaseSchedule: Report results and deprovision
Loading

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The new echo "Configured noProxy: ${NO_PROXY}" logs api-int.<cluster>.<baseDomain> and other cluster network data, exposing internal hostnames in CI logs. Remove the full noProxy log or redact hostnames and network CIDRs; log only safe metadata such as entry counts.
Test Structure And Quality ❓ Inconclusive The working tree has no diff, so changed-code evidence is unavailable; need the pull-request base/head diff to assess Ginkgo test changes. Provide a usable pull-request base/head diff or checkout containing the changed files.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the addition of metal SNO IPv6 HTTP proxy jobs across OpenShift 4.18 through 5.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR diff adds CI workflows, job configuration, and shell logic only; it introduces no Ginkgo It/Describe/Context/When calls or dynamic test titles.
Microshift Test Compatibility ✅ Passed The PR diff adds CI YAML, metadata, ownership links, and shell configuration only; it adds no Ginkgo declarations or Go e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The full diff adds CI workflows/jobs and shell configuration only; it adds no Ginkgo test declarations or test source files, so this SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds CI job topology parameters, step-registry workflow/chain entries, and proxy/GRUB scripts; the diff adds no Kubernetes workload manifests or listed scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML/metadata/OWNERS and two Bash step scripts; no Go OTE binary or suite setup is changed. The added echo is in a CI shell step, outside this contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR diff adds CI YAML, workflow metadata, OWNERS files, and shell scripts, but no new Ginkgo declarations such as It, Describe, Context, or When; this check is inapplicable.
No-Weak-Crypto ✅ Passed The base-to-tip diff adds workflows/configuration plus proxy and GRUB conditionals; targeted searches found no MD5/SHA1/DES/RC4/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The merge-base diff adds no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings; capabilities entries are CI intranet labels.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml`:
- Around line 5545-5559: Regenerate the Prow job configuration by running make
update, then commit all resulting generated metadata and job changes for
metal-sno-ipv6-http-proxy-f28 in
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml#L5545-L5559
and
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__arm64-nightly.yaml#L658-L674,
and for metal-sno-ipv6-http-proxy-f7 in
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml#L5765-L5779,
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yaml#L699-L715,
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml#L4870-L4884,
and
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly.yaml#L658-L674.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a6f9e9c5-67c6-4521-b782-c77885eb46b8

📥 Commits

Reviewing files that changed from the base of the PR and between 1c125d2 and 57618a9.

⛔ Files ignored due to path filters (6)
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (18)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18__arm64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__arm64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__arm64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__arm64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly.yaml
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/OWNERS
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/baremetal-lab-sno-ipv6-static-workflow.metadata.json
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/baremetal-lab-sno-ipv6-static-workflow.yaml
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/conf/OWNERS
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/conf/baremetal-lab-sno-ipv6-static-conf-chain.metadata.json
  • ci-operator/step-registry/baremetal/lab/sno/ipv6/static/conf/baremetal-lab-sno-ipv6-static-conf-chain.yaml

Comment on lines +5545 to +5559
- as: metal-sno-ipv6-http-proxy-f28
capabilities:
- intranet
cron: 17 3 6,20 * *
steps:
cluster_profile: equinix-ocp-metal-qe
env:
AUX_HOST: openshift-qe-metal-ci.arm.eng.rdu2.redhat.com
RESERVE_BOOTSTRAP: "false"
architecture: amd64
masters: "1"
workers: "0"
test:
- chain: openshift-e2e-test-qe
workflow: baremetal-lab-sno-ipv6-static

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Regenerate Prow jobs for the new periodic test definitions.

Each added test changes the generated Prow job configuration. Run make update and commit the resulting generated metadata and Prow job changes. Without those generated jobs, Prow will not schedule this periodic coverage.

  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml#L5545-L5559: regenerate the job for metal-sno-ipv6-http-proxy-f28.
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__arm64-nightly.yaml#L658-L674: regenerate the ARM64 job for metal-sno-ipv6-http-proxy-f28.
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml#L5765-L5779: regenerate the AMD64 job for metal-sno-ipv6-http-proxy-f7.
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yaml#L699-L715: regenerate the ARM64 job for metal-sno-ipv6-http-proxy-f7.
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml#L4870-L4884: regenerate the AMD64 job for metal-sno-ipv6-http-proxy-f7.
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly.yaml#L658-L674: regenerate the ARM64 job for metal-sno-ipv6-http-proxy-f7.

As per coding guidelines, CI configuration changes must run make update. Based on learnings, added test definitions are structural changes that require regenerated Prow job definitions.

📍 Affects 6 files
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml#L5545-L5559 (this comment)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__arm64-nightly.yaml#L658-L674
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml#L5765-L5779
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yaml#L699-L715
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml#L4870-L4884
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly.yaml#L658-L674
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml`
around lines 5545 - 5559, Regenerate the Prow job configuration by running make
update, then commit all resulting generated metadata and job changes for
metal-sno-ipv6-http-proxy-f28 in
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml#L5545-L5559
and
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__arm64-nightly.yaml#L658-L674,
and for metal-sno-ipv6-http-proxy-f7 in
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml#L5765-L5779,
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yaml#L699-L715,
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml#L4870-L4884,
and
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly.yaml#L658-L674.

Sources: Coding guidelines, Learnings

Use one-level OWNERS symlinks to match baremetal lab conventions and
resolve do-not-merge/invalid-owners-file on the PR.
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

Required by ci/prow/owners for new step-registry component paths.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-release-master-periodic-ci-openshift-openshift-tests-private-release-4.22-periodics-metal-sno-ipv6-http-proxy-f7

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

  Two issues were preventing SNO IPv6 with HTTP proxy from bootstrapping:

  1. ipi-conf-proxy: Missing noProxy configuration caused installer to
     route cluster-internal API traffic through the proxy. Now dynamically
     builds noProxy list from cluster/service/machine CIDRs and domain.

  2. baremetal-lab-upi-conf-grub2-ipv6-static: Missing BOOTSTRAP_IN_PLACE
     check caused SNO to fetch wrong ignition file. Now matches IPv4 logic
     to use bootstrap.ign for SNO instead of console-hook.ign.

  Fixes: OCPQE-30425
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snaoum-lang
Once this PR has been reviewed and has the lgtm label, please assign sgoveas, xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/step-registry/ipi/conf/proxy/ipi-conf-proxy-commands.sh`:
- Around line 29-41: Initialize CLUSTER_CIDRS, SERVICE_CIDRS, and MACHINE_CIDRS
to empty values before the NETWORK_PATCH file-existence check, so nounset-safe
references later in the script remain defined when the optional patch is absent.
Preserve the existing extraction and NO_PROXY updates inside the conditional
block.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 671c0584-50ef-4c0d-abdb-77ef144e014e

📥 Commits

Reviewing files that changed from the base of the PR and between d5d6ff0 and 8e78610.

📒 Files selected for processing (2)
  • ci-operator/step-registry/baremetal/lab/upi/conf/grub2/ipv6/static/baremetal-lab-upi-conf-grub2-ipv6-static-commands.sh
  • ci-operator/step-registry/ipi/conf/proxy/ipi-conf-proxy-commands.sh

Comment on lines +29 to +41
NETWORK_PATCH="${SHARED_DIR}/network_patch_install_config.yaml"
if [ -f "${NETWORK_PATCH}" ]; then
# Extract cluster network CIDRs from patch
CLUSTER_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.clusterNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${CLUSTER_CIDRS}" ] && NO_PROXY="${NO_PROXY},${CLUSTER_CIDRS}"

# Extract service network CIDRs from patch
SERVICE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.serviceNetwork[*]' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${SERVICE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${SERVICE_CIDRS}"

# Extract machine network CIDRs from patch
MACHINE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.machineNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${MACHINE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${MACHINE_CIDRS}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Initialize the CIDR variables before the optional patch check.

If ${SHARED_DIR}/network_patch_install_config.yaml is absent, Lines 55, 59, and 63 expand unset variables. set -o nounset then terminates the step before it can read network values from install-config.yaml.

Proposed fix
 NETWORK_PATCH="${SHARED_DIR}/network_patch_install_config.yaml"
+CLUSTER_CIDRS=""
+SERVICE_CIDRS=""
+MACHINE_CIDRS=""
+
 if [ -f "${NETWORK_PATCH}" ]; then
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
NETWORK_PATCH="${SHARED_DIR}/network_patch_install_config.yaml"
if [ -f "${NETWORK_PATCH}" ]; then
# Extract cluster network CIDRs from patch
CLUSTER_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.clusterNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${CLUSTER_CIDRS}" ] && NO_PROXY="${NO_PROXY},${CLUSTER_CIDRS}"
# Extract service network CIDRs from patch
SERVICE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.serviceNetwork[*]' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${SERVICE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${SERVICE_CIDRS}"
# Extract machine network CIDRs from patch
MACHINE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.machineNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${MACHINE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${MACHINE_CIDRS}"
NETWORK_PATCH="${SHARED_DIR}/network_patch_install_config.yaml"
CLUSTER_CIDRS=""
SERVICE_CIDRS=""
MACHINE_CIDRS"
if [ -f "${NETWORK_PATCH}" ]; then
# Extract cluster network CIDRs from patch
CLUSTER_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.clusterNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${CLUSTER_CIDRS}" ] && NO_PROXY="${NO_PROXY},${CLUSTER_CIDRS}"
# Extract service network CIDRs from patch
SERVICE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.serviceNetwork[*]' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${SERVICE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${SERVICE_CIDRS}"
# Extract machine network CIDRs from patch
MACHINE_CIDRS=$(yq-go r "${NETWORK_PATCH}" 'networking.machineNetwork[*].cidr' 2>/dev/null | tr '\n' ',' | sed 's/,$//')
[ -n "${MACHINE_CIDRS}" ] && NO_PROXY="${NO_PROXY},${MACHINE_CIDRS}"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/step-registry/ipi/conf/proxy/ipi-conf-proxy-commands.sh` around
lines 29 - 41, Initialize CLUSTER_CIDRS, SERVICE_CIDRS, and MACHINE_CIDRS to
empty values before the NETWORK_PATCH file-existence check, so nounset-safe
references later in the script remain defined when the optional patch is absent.
Preserve the existing extraction and NO_PROXY updates inside the conditional
block.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

  The step was failing with 'unbound variable' error because the script
  references BOOTSTRAP_IN_PLACE but it wasn't defined in the ref.yaml.

  Added BOOTSTRAP_IN_PLACE env variable with default 'false'. The workflow
  overrides this to 'true' for SNO deployments to use bootstrap.ign instead
  of console-hook.ign files.
@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

… jobs.

Split versions across architectures following existing metal IPv6 job pattern.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA d2dce91592d5a160f778c3487b212f9a0fc0791a: error checking out "d2dce91592d5a160f778c3487b212f9a0fc0791a": exit status 128 fatal: unable to read tree (d2dce91592d5a160f778c3487b212f9a0fc0791a)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

  After patching image-registry, kube-apiserver and openshift-apiserver
  may return ServiceUnavailable during rollouts, causing oc wait to fail
  immediately and killing the install step under set -o errexit. Split
  the combined wait into per-operator loops with up to 5 retries and 60s
  delay to handle transient unavailability gracefully.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@snaoum-lang: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-autoscaler-main-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-5.1-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-5.0-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.23-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.22-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.21-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.20-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.19-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-kubernetes-autoscaler-release-4.18-regression-clusterinfra-aws-ipi-proxy-autoscaler openshift/kubernetes-autoscaler presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-5.1-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-5.0-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.23-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.22-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.21-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.20-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.19-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.18-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.17-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.16-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.15-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.14-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-csi-file-cross-subscription openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-5.1-e2e-azure-csi-file-cross-subscription openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-5.0-e2e-azure-csi-file-cross-subscription openshift/azure-file-csi-driver presubmit Registry content changed

A total of 1570 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@snaoum-lang

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@snaoum-lang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7 b94fc06 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-sno-ipv6-http-proxy-f7
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28 59b77d5 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-metal-sno-ipv6-http-proxy-f28

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants