Pgeditor critic dark mode#3016
Merged
Alex-Jordan merged 1 commit intoJun 11, 2026
Merged
Conversation
This is basically the same fix used for the hardcopy theme xml preview. This just adds the `text-dark` class to the container. Also switch the "Loading..." placeholder that shows while a problem is rendering to using the `bg-secondary-subtle` background instead of the `bg-secondary` background. The `bg-secondary-subtle` background is responsive to the color scheme, and so works for both light or dark mode.
somiaj
approved these changes
Jun 10, 2026
Alex-Jordan
approved these changes
Jun 11, 2026
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jun 25, 2026
This reworks what was done in openwebwork#3008 and openwebwork#3016. Rather than trying to force the PG critic and hardcopy xml into light mode, remove the `bg-white` class from the render panel and use the page colors. This means that these things are in a proper dark mode for those that use it. Problems do not need the white background since by default iframes are given a white background. Also the iframe elements do not need to have the `color-scheme` style set to `light`. That has no effect inside the iframe anyway.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jul 2, 2026
This reworks what was done in openwebwork#3008 and openwebwork#3016. Rather than trying to force the PG critic and hardcopy xml into light mode, remove the `bg-white` class from the render panel and use the page colors. This means that these things are in a proper dark mode for those that use it. Problems do not need the white background since by default iframes are given a white background. Also the iframe elements do not need to have the `color-scheme` style set to `light`. That has no effect inside the iframe anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the same fix used for the hardcopy theme xml preview. This just adds the
text-darkclass to the container.Also switch the "Loading..." placeholder that shows while a problem is rendering to using the
bg-secondary-subtlebackground instead of thebg-secondarybackground. Thebg-secondary-subtlebackground is responsive to the color scheme, and so works for both light or dark mode.Maybe this fixes all the cases for the editor now?