Refactor legacy upgrade constraint semantics - #450
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
- Coverage 84.00% 83.62% -0.38%
==========================================
Files 23 23
Lines 844 849 +5
==========================================
+ Hits 709 710 +1
- Misses 93 95 +2
- Partials 42 44 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m1kola
marked this pull request as ready for review
October 10, 2023 12:33
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
4 tasks
m1kola
commented
Oct 10, 2023
| return &InstalledPackageVariableSource{ | ||
| catalogClient: catalogClient, | ||
| bundleImage: bundleImage, | ||
| successors: legacySemanticsSuccessors, |
Member
Author
There was a problem hiding this comment.
Context: this will be swapable based on feature gate. More to come in #444.
joelanford
reviewed
Oct 10, 2023
joelanford
reviewed
Oct 10, 2023
joelanford
left a comment
joelanford
left a comment
Member
There was a problem hiding this comment.
Looks good to me, after addressing my comment about use of require vs assert testify packages in the tests.
* Make successors func swappable * Update test to not use Ginkgo & prepare the test to be able to switch between different states of the `ForceSemverUpgradeConstraints` feature flag Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
397_refactor_legacy
branch
from
October 10, 2023 13:30
616bd9f to
0b031ec
Compare
joelanford
approved these changes
Oct 10, 2023
m1kola
added this pull request to the merge queue
Oct 10, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2023
m1kola
added this pull request to the merge queue
Oct 10, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2023
m1kola
added this pull request to the merge queue
Oct 10, 2023
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
…rk#450) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.2 to 1.35.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.2...v1.35.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ForceSemverUpgradeConstraintsfeature flagCloses #397
Reviewer Checklist