[#636] macOS에서는 토스트가 상단에 뜨도록 수정한다#638
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic toast placement to support displaying toasts at the top when running as an iOS app on Mac. The review feedback suggests utilizing SwiftUI's @Environment(\.isiOSAppOnMac) instead of directly accessing ProcessInfo to improve testability and preview support, which also allows for the removal of the static current property.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
Apple Silicon Mac 환경에서 토스트가 화면 하단이 아니라 상단에서 아래 방향으로 표시되도록 동작 분기
📝 작업 내용
📌 요약
ToastPresentationPlacement추가🔍 상세
ToastHostModifier의 overlay alignment를 고정.bottom에서 placement 기반 alignment로 변경-50에서 placement 기반 offset으로 변경📸 영상 / 이미지 (Optional)