[#609] 서비스 레이어의 Firebase 작업을 트랜잭션화한다#642
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 Firestore 트랜잭션을 적용하여 데이터 일관성을 보장하고, 기존의 비동기 병렬 처리 방식을 트랜잭션 기반으로 리팩토링하는 변경사항을 포함하고 있습니다. 구체적으로는 알림 읽음 처리, 애플 리프레시 토큰 삭제, 할 일 추가 및 사용자 문서 업서트 로직에 트랜잭션을 도입하였습니다. 리뷰 의견으로는 PushNotificationServiceImpl 내 트랜잭션의 catch 블록에서 에러 설정 후 즉시 return nil을 수행하도록 하여, 향후 코드 수정 시 발생할 수 있는 잠재적인 버그를 방지하고 타 서비스와의 일관성을 유지할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
UserServiceImpl.upsertUser에서users,info,tokens,settings,todoCounter문서 갱신을runTransaction내부로 이동PushNotificationServiceImpl.toggleNotificationRead에서 알림 문서의isRead값을 transaction 내부에서 다시 읽고 반전 업데이트하도록 변경AppleAuthenticationServiceImpl.unlink에서appleRefreshToken삭제 전 문서 확인과 필드 삭제를 transaction 내부에서 처리.hermes/skills/devlog-architecture-harness/references/devlog-workflow-rules.md에 merge commit body 또는 non-merge commit 기준으로 커밋 메시지 스타일을 확인하는 지침 추가📸 영상 / 이미지 (Optional)