-
Notifications
You must be signed in to change notification settings - Fork 0
[#596] SearchView에서 '#' 뒤 숫자를 입력했을 때 숫자 기반이 아닌 문자열 기반으로 검색하도록 수정한다 #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
Application/DevLogInfra/Tests/Service/TodoSearchMatchingTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // | ||
| // TodoSearchMatchingTests.swift | ||
| // DevLogInfraTests | ||
| // | ||
| // Created by opfic on 6/26/26. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Testing | ||
| import DevLogData | ||
| @testable import DevLogInfra | ||
|
|
||
| struct TodoSearchMatchingTests { | ||
| @Test("#숫자 검색어는 Todo 번호를 문자열 기반으로 부분 검색한다") | ||
| func 해시_숫자_검색어는_Todo_번호를_문자열_기반으로_부분_검색한다() { | ||
| let todo = makeTodo(number: 123) | ||
| let numberKeyword = TodoResponse.normalizedNumberKeyword(from: "#0001") | ||
|
|
||
| #expect(todo.matchesSearchKeyword("#1")) | ||
| #expect(todo.matchesSearchKeyword("#12")) | ||
| #expect(todo.matchesSearchKeyword("#0001")) | ||
| #expect(todo.matchesSearchKeyword("#0001", numberKeyword: numberKeyword)) | ||
| } | ||
|
|
||
| @Test("# 단독 검색어는 Todo 번호로 매칭하지 않는다") | ||
| func 해시_단독_검색어는_Todo_번호로_매칭하지_않는다() { | ||
| let todo = makeTodo(number: 123) | ||
|
|
||
| #expect(!todo.matchesSearchKeyword("#")) | ||
| } | ||
|
|
||
| private func makeTodo(number: Int) -> TodoResponse { | ||
| TodoResponse( | ||
| id: "todo-id", | ||
| isPinned: false, | ||
| isCompleted: false, | ||
| isChecked: false, | ||
| number: number, | ||
| title: "title", | ||
| content: "content", | ||
| createdAt: .now, | ||
| updatedAt: .now, | ||
| completedAt: nil, | ||
| deletedAt: nil, | ||
| dueDate: nil, | ||
| tags: [], | ||
| category: .raw("feature") | ||
| ) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.