Skip to content

GraphQL Docs for Parse Server 3.10.0#688

Merged
TomWFox merged 43 commits into
parse-community:gh-pagesfrom
Moumouls:graphql
Jan 12, 2020
Merged

GraphQL Docs for Parse Server 3.10.0#688
TomWFox merged 43 commits into
parse-community:gh-pagesfrom
Moumouls:graphql

Conversation

@Moumouls

@Moumouls Moumouls commented Nov 30, 2019

Copy link
Copy Markdown
Member

GraphQL Doc

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! This is what I've got so far...

General notes:

  • Perhaps ease up on the bold formatting
  • Maybe run a spell check - I've highlighted some but I'm sure I've missed others

Comment thread _includes/graphql/classes.md Outdated
Comment thread _includes/graphql/files.md Outdated
Comment thread _includes/graphql/files.md Outdated
Comment thread _includes/graphql/getting-started.md Outdated
Comment thread _includes/graphql/getting-started.md Outdated
Comment thread _includes/graphql/relay.md Outdated
Comment thread _includes/graphql/relay.md Outdated
Comment thread _includes/graphql/relay.md Outdated
Comment thread _includes/graphql/relay.md Outdated
Comment thread _includes/graphql/users.md Outdated
@Moumouls

Moumouls commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

@TomWFox yes i need support of a native english contributor on this doc. I'm French (Baguette) so it's not the best English you can find right now 😄

Could you help on this ?

With my last commit, i think that we have a good start, but tomorrow is my last Open Source Day of the week, and i want to work on missing features of the GraphQL implementation...

@omairvaiyani @davimacedo

Moumouls and others added 18 commits December 2, 2019 18:53
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls

Moumouls commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

@TomWFox thanks for the first review ! 😃

Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls

Moumouls commented Dec 7, 2019

Copy link
Copy Markdown
Member Author

@TomWFox it's strange, i sent batch commit but still conserve Changes requested state...

@Moumouls Moumouls requested a review from TomWFox December 7, 2019 16:27
@davimacedo

Copy link
Copy Markdown
Member

@TomWFox Since 3.10 was launched with the breaking changes, it is important to release this update ASAP. Can I merge and we can do any correction/improvement later?

@TomWFox

TomWFox commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

Ah ok, I didn't realise we were going for a 3.10 release, there are definitely still changes to be made but I think its mainly grammatical stuff so its not the end of the world to merge now

@Moumouls

Moumouls commented Jan 9, 2020

Copy link
Copy Markdown
Member Author

Please just make a last spell check (due to my french English ☺️) then we can merge !

@TomWFox

TomWFox commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

I can do that tomorrow.

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked 7 of 17 files so far, here is what I have, I'll get to the rest later.

Comment thread _includes/graphql/files.md Outdated
Comment thread _includes/graphql/files.md Outdated
Comment thread _includes/graphql/files.md Outdated
Comment thread _includes/graphql/getting-started.md Outdated
Comment thread _includes/graphql/getting-started.md Outdated
Comment thread _includes/graphql/objects.md Outdated
Comment thread _includes/graphql/objects.md Outdated
Comment thread _includes/graphql/optimization.md Outdated

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some more, @Moumouls if its ok with you I think it would be much quicker for me to make commits with changes directly.

Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Comment thread _includes/graphql/optimization.md Outdated
Moumouls and others added 5 commits January 10, 2020 23:27
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@TomWFox

TomWFox commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

@Moumouls I've unresolved the earlier review comments from @omairvaiyani that you marked as resolved because I checked the first two and the changes haven't been applied.

Could you apply the suggestions or discuss with Omair if you disagree?

@TomWFox TomWFox self-requested a review January 12, 2020 16:34

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I've applied all the suggestions (or similar) from @omairvaiyani, checked all the files and made any changes I thought were necessary and I've built the site and its looking ok.

So... I think this is good enough to merge!

@TomWFox TomWFox merged commit 3341e7b into parse-community:gh-pages Jan 12, 2020
@TomWFox TomWFox changed the title WIP: GraphQL Docs GraphQL Docs for Parse Server 3.10.0 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants