Makes sure we don't duplicate user ACL's keys#2651
Merged
Conversation
ghost
added
the
Current coverage is 92.10% (diff: 100%)@@ master #2651 diff @@
==========================================
Files 100 100
Lines 12282 12288 +6
Methods 1522 1522
Messages 0 0
Branches 2020 2020
==========================================
+ Hits 11313 11318 +5
- Misses 969 970 +1
Partials 0 0
|
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
Contributor
Author
|
Fixes #2431 This issue was caused by the mutation roles array, as we don't mutate anymore the issue will be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using 'include' the userACL would see it's length grow for each subquery.
This fix prevents this behaviour by concatenating the results for the auth.getUserAndRoleACL to the current findOptions.acl.
When the userACL length is > 1 in DatabaseController we also consider it invalid, therefore rendering the query wrong.
Fixes #2246