Skip to content

Pass context in beforeDelete, afterDelete, beforeFind and Parse.Cloud.run.#6666

Merged
mtrezza merged 16 commits into
parse-community:masterfrom
yog27ray:add-context-to-pending-hooks
Jul 10, 2020
Merged

Pass context in beforeDelete, afterDelete, beforeFind and Parse.Cloud.run.#6666
mtrezza merged 16 commits into
parse-community:masterfrom
yog27ray:add-context-to-pending-hooks

Conversation

@yog27ray

@yog27ray yog27ray commented May 3, 2020

Copy link
Copy Markdown
Contributor

This extension the of the #6626. To pass context in following calls.

  1. beforeDelete
  2. afterDelete
  3. beforeFind
  4. Cloud Function

Don't merge until

@mtrezza

mtrezza commented May 31, 2020

Copy link
Copy Markdown
Member

@yog27ray Do you need any help with the failing cases?

@yog27ray

Copy link
Copy Markdown
Contributor Author

@mtrezza these failing test cases depends on parse-community/Parse-SDK-JS#1159

@mtrezza

mtrezza commented Jun 20, 2020

Copy link
Copy Markdown
Member

Got it. Amazing work to see the context now expanded to all these methods! 👍

I should mention some pitfalls I came across with the original PR for save, namely the different routes that need to be considered. Maybe that is also relevant for this PR, see the fix #6736.

@dplewis

dplewis commented Jun 20, 2020

Copy link
Copy Markdown
Member

Can you guys tag team this issue here #6736

Sorry I’m kinda out of the loop which is why I didn’t merge the SDK PR

@mtrezza

mtrezza commented Jun 20, 2020

Copy link
Copy Markdown
Member

@dplewis Issue #6736 should be done, it only needs merging of the 2 related PRs. I think after that it makes sense to merge this PR, as it’s an extension of #6736 which is an extension of #6459 as I understand it.

@marcinjakubowski

Copy link
Copy Markdown

any idea when these context changes may be merged?

 into add-context-to-pending-hooks

� Conflicts:
�	spec/CloudCode.spec.js
@yog27ray

yog27ray commented Jul 4, 2020

Copy link
Copy Markdown
Contributor Author

@dplewis on travis failing test cases are passing in my local. Can you help me how can I replicate the same.

Comment thread spec/CloudCode.spec.js Outdated
@codecov

codecov Bot commented Jul 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #6666 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6666      +/-   ##
==========================================
- Coverage   93.90%   93.89%   -0.01%     
==========================================
  Files         169      169              
  Lines       12048    12047       -1     
==========================================
- Hits        11314    11312       -2     
- Misses        734      735       +1     
Impacted Files Coverage Δ
src/GraphQL/helpers/objectsQueries.js 90.83% <ø> (ø)
src/GraphQL/loaders/usersQueries.js 97.50% <ø> (ø)
src/ParseServerRESTController.js 98.18% <ø> (ø)
src/Routers/AggregateRouter.js 100.00% <ø> (ø)
src/Routers/AudiencesRouter.js 100.00% <ø> (ø)
src/Routers/ClassesRouter.js 97.93% <ø> (ø)
src/Routers/CloudCodeRouter.js 100.00% <ø> (ø)
src/Routers/FunctionsRouter.js 94.87% <ø> (ø)
src/Routers/IAPValidationRouter.js 85.00% <ø> (ø)
src/Routers/InstallationsRouter.js 83.33% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f095dff...8fde167. Read the comment docs.

@mtrezza

mtrezza commented Jul 4, 2020

Copy link
Copy Markdown
Member

on travis failing test cases are passing in my local. Can you help me how can I replicate the same.

These seem to be randomly failing tests, unrelated to your PR, see #6758. I restarted the build and the tests pass.

Comment thread spec/CloudCode.spec.js Outdated

@mtrezza mtrezza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for removing the lint changes, much easier to read now. Just some minor comments, can you please take another look?

Comment thread spec/CloudCode.spec.js Outdated
Comment thread spec/CloudCode.spec.js Outdated
Comment thread spec/ParseACL.spec.js Outdated
Comment thread src/GraphQL/helpers/objectsMutations.js
Comment thread src/Routers/ClassesRouter.js
Comment thread src/Routers/CloudCodeRouter.js Outdated
Comment thread src/Routers/ClassesRouter.js
@yog27ray

yog27ray commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

@mtrezza can you restart the build.

@mtrezza

mtrezza commented Jul 8, 2020

Copy link
Copy Markdown
Member

Done. You can also restart the build by pushing an empty commit git commit --allow-empty -m "Trigger Travis-CI"

@dplewis dplewis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants