fix: Server does not start via CLI when `auth` option is set by dblythy · Pull Request #8666 · parse-community/parse-server

dblythy · 2023-06-26T07:30:30Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Auth settings cannot be defined by json.

Closes: #8665

Approach

First commit is a failing test

Tasks

Add tests

parse-github-assistant · 2023-06-26T07:30:33Z

Thanks for opening this pull request!

dblythy · 2023-06-26T07:41:38Z

https://github.com/parse-community/parse-server/actions/runs/5375104603/jobs/9751171185?pr=8666

codecov · 2023-06-26T07:50:19Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (446cbb1) 94.37% compared to head (d7eff74) 94.38%.

❗ Current head d7eff74 differs from pull request most recent head 11f48f9. Consider uploading reports for the commit 11f48f9 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #8666   +/-   ##
=======================================
  Coverage   94.37%   94.38%           
=======================================
  Files         185      185           
  Lines       14758    14758           
=======================================
+ Hits        13928    13929    +1     
+ Misses        830      829    -1

Impacted Files	Coverage Δ
src/Options/Definitions.js	`100.00% <ø> (ø)`
src/Options/index.js	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dblythy · 2023-06-26T11:10:04Z

@FransGH would you be willing to try this PR out and let us know if it resolves the issue you’ve had?

Let me know if you’d like another PR based on the LTS branch, I’d be happy to sort that out.

npm install dblythy/parse-server#fix-auth-parser

FransGH · 2023-06-26T11:25:11Z

@dblythy thx, I'll try it out on staging now!

FransGH · 2023-06-26T11:52:29Z

@dblythy couldn't get it working yet, likely has nothing to do with the PR. When I replace v5.5.1 with "dblythy/parse-server#fix-auth-parser" I'm getting:

"WARNING, Unable to connect to 'http://localhost:1340/sel'. Cloud code and push notifications may be unavailable"!

Need to go now but will try to get your branch running asap. Is the LTS branch "5.5.x" or what release is your fork based on?
(I've not yet upgraded to 6.x as I stumbled on other breaking changes)

dblythy · 2023-06-26T11:53:59Z

This PR is based on Parse Server 6, I can pretty easily create another PR based on the LTS branch. I'll have that for you tomorrow.

mtrezza

The Postgres test are consistently failing with:

execution can start Parse Server with auth via CLI

Error: Timeout - Async function did not complete within 20000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)

mtrezza

Looks good!

# [6.3.0-alpha.4](6.3.0-alpha.3...6.3.0-alpha.4) (2023-07-04) ### Bug Fixes * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b))

parseplatformorg · 2023-07-04T11:18:38Z

🎉 This change has been released in version 6.3.0-alpha.4

# [6.4.0-beta.1](6.3.0...6.4.0-beta.1) (2023-09-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-09-16T02:54:18Z

🎉 This change has been released in version 6.4.0-beta.1

# [6.4.0-alpha.1](6.3.0...6.4.0-alpha.1) (2023-09-20) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-09-20T08:51:02Z

🎉 This change has been released in version 6.4.0-alpha.1

# [6.4.0](6.3.1...6.4.0) (2023-11-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-11-16T15:28:24Z

🎉 This change has been released in version 6.4.0

fix: Auth does not load when starting Parse Server via CLI

d48ae99

fix definition

88d9d6a

dblythy mentioned this pull request Jun 27, 2023

fix: Server does not start via CLI when auth option is set #8669

Merged

dblythy requested a review from a team June 28, 2023 02:06

mtrezza changed the title ~~fix: Auth does not load when starting Parse Server via CLI~~ fix: Server does not start via CLI when the auth option is set Jun 28, 2023

mtrezza changed the title ~~fix: Server does not start via CLI when the auth option is set~~ fix: Server does not start via CLI with auth option set Jun 28, 2023

mtrezza changed the title ~~fix: Server does not start via CLI with auth option set~~ fix: Server does not start via CLI when auth option is set Jun 28, 2023

FransGH mentioned this pull request Jun 28, 2023

Inconsistent config validation when starting a server instance via CLI vs. API #8673

Open

3 tasks

mtrezza requested changes Jun 28, 2023

View reviewed changes

dblythy added 4 commits June 29, 2023 13:18

Merge branch 'alpha' into fix-auth-parser

4dcddb6

Update CLI.spec.js

c729d94

Update CLI.spec.js

238d681

Update CLI.spec.js

aeb8017

dblythy requested a review from a team June 29, 2023 04:56

mtrezza reviewed Jun 29, 2023

View reviewed changes

Comment thread src/Options/index.js

Merge branch 'alpha' into fix-auth-parser

11f48f9

mtrezza approved these changes Jul 4, 2023

View reviewed changes

mtrezza merged commit 4e2000b into parse-community:alpha Jul 4, 2023

parseplatformorg added the state:released-alpha Released as alpha version label Jul 4, 2023

dblythy deleted the fix-auth-parser branch July 4, 2023 11:48

parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023

parseplatformorg added the state:released Released as stable version label Nov 16, 2023

Uh oh!

Conversation

dblythy commented Jun 26, 2023

Pull Request

Issue

Approach

Tasks

Uh oh!

parse-github-assistant Bot commented Jun 26, 2023

Thanks for opening this pull request!

Uh oh!

dblythy commented Jun 26, 2023

Uh oh!

codecov Bot commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dblythy commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FransGH commented Jun 26, 2023

Uh oh!

FransGH commented Jun 26, 2023

Uh oh!

dblythy commented Jun 26, 2023

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

parseplatformorg commented Jul 4, 2023

Uh oh!

parseplatformorg commented Sep 16, 2023

Uh oh!

parseplatformorg commented Sep 20, 2023

Uh oh!

parseplatformorg commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jun 26, 2023 •

edited

Loading

dblythy commented Jun 26, 2023 •

edited

Loading