feat(Chatbot): applied glass and felt tokens #849
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,6 +203,20 @@ | |
| } | ||
| } | ||
|
|
||
| .pf-chatbot:is(.pf-chatbot--drawer, .pf-chatbot--docked) .pf-chatbot__history { | ||
| // .pf-v6-c-menu { | ||
| // @at-root :where(.pf-v6-theme-glass) & { | ||
| // --pf-v6-c-menu--BackgroundColor: var(--pf-t--global--background--color--floating--default); | ||
| // } | ||
| // } | ||
|
|
||
| // .pf-chatbot__menu-item-header > .pf-v6-c-menu__group-title { | ||
| // @at-root :where(.pf-v6-theme-glass) & { | ||
| // background-color: var(--pf-t--global--background--color--floating--default); | ||
| // } | ||
| // } | ||
| } | ||
|
|
||
| // ============================================================================ | ||
| // Chatbot Display Mode - Docked | ||
| // ============================================================================ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,7 @@ | |
| // ============================================================================ | ||
| .pf-chatbot__footer { | ||
| --pf-chatbot__footer--RowGap: var(--pf-t--global--spacer--md); | ||
| background-color: var(--pf-t--global--background--color--floating--secondary--default); | ||
| display: flex; | ||
| flex-direction: column; | ||
| row-gap: var(--pf-chatbot__footer--RowGap); | ||
|
|
@@ -19,6 +16,17 @@ | |
| background-color: var(--pf-t--global--background--color--primary--default); | ||
| } | ||
| } | ||
|
|
||
| .pf-chatbot:not(.pf-chatnot--default) { | ||
| .pf-chatbot__footer { | ||
| background-color: var(--pf-t--global--background--color--secondary--default); | ||
|
|
||
| @at-root :where(.pf-v6-theme-glass) & { | ||
| background-color: var(--pf-t--global--background--color--glass--primary--default); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .pf-chatbot__footer-container { | ||
| padding: 0 var(--pf-t--global--spacer--lg) var(--pf-t--global--spacer--lg) var(--pf-t--global--spacer--lg); | ||
| display: flex; | ||
|
|
@@ -35,12 +43,6 @@ | |
| .pf-chatbot--fullscreen { | ||
| .pf-chatbot__footer { | ||
| align-items: center; | ||
| } | ||
|
|
||
| .pf-chatbot__footer-container { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,7 @@ | |
| grid-template-columns: 1fr auto; | ||
| gap: var(--pf-t--global--spacer--sm); | ||
| position: relative; // this is so focus ring on parent chatbot doesn't include header | ||
| background-color: var(--pf-t--global--background--color--floating--secondary--default); | ||
| justify-content: space-between; | ||
| padding: var(--pf-t--global--spacer--lg); | ||
|
|
||
|
|
@@ -58,28 +55,13 @@ | |
| } | ||
| } | ||
|
|
||
| .pf-chatbot:not(.pf-chatbot--default) { | ||
| .pf-chatbot__header { | ||
| background-color: var(--pf-t--global--background--color--secondary--default); | ||
|
|
||
| @at-root :where(.pf-v6-theme-glass) & { | ||
| background-color: var(--pf-t--global--background--color--glass--primary--default); | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -98,12 +80,6 @@ | |
| border-radius: inherit; | ||
| } | ||
|
|
||
| .pf-v6-c-button__icon, | ||
| .pf-v6-c-menu-toggle__icon { | ||
| display: flex; | ||
|
|
@@ -122,13 +98,6 @@ | |
| } | ||
| } | ||
|
|
||
| // ============================================================================ | ||
| // Examples | ||
| // ============================================================================ | ||
|
|
@@ -169,18 +138,3 @@ | |
| .pf-chatbot__header .pf-chatbot__actions .pf-v6-c-menu-toggle.pf-m-secondary.pf-m-compact { | ||
| width: initial; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ import { | |
| Icon, | ||
| MenuToggleProps | ||
| } from '@patternfly/react-core'; | ||
| import RhUiEllipsisHorizontalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-horizontal-fill-icon'; | ||
|
|
||
| export interface ChatbotHeaderOptionsDropdownProps extends Omit<DropdownProps, 'toggle'> { | ||
| /** Content to be displayed in the chatbot header */ | ||
|
|
@@ -56,7 +56,7 @@ export const ChatbotHeaderOptionsDropdown: FunctionComponent<ChatbotHeaderOption | |
| ref={toggleRef} | ||
| icon={ | ||
| <Icon size={isCompact ? 'lg' : 'xl'} isInline> | ||
| <RhUiEllipsisHorizontalFillIcon /> | ||
| </Icon> | ||
| } | ||
| isExpanded={isOptionsMenuOpen} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have a glass box-shadow token (
--pf-t--global--box-shadow--glass--default) if that's the intent here. It resolves to--md, but if design ever decided to update the default glass container box-shadow, using the glass token would get that update where using--mdwouldn't. Though up to design if that's the intent of this shadow, or if it should be fixed at--md