feat: listbox elements - #2570

Merged

bennypowers merged 405 commits into

mainfrom

menu-dropdown-listbox

Jan 19, 2024

This pull request is big! We're only showing the most recent 250 commits

Commits on Sep 7, 2023

feat(dropdown): matched styling and demos to upstream
Nikki Massaro Kauffman
committed
feat(dropdown): cleaned up docs
Nikki Massaro Kauffman
committed
feat(dropdown): updated divider css
Nikki Massaro Kauffman
committed
fix(dropdown): fixed aria-haspopus
Nikki Massaro Kauffman
committed

Commits on Sep 8, 2023

feat(select): implements suggested update to SVG size

nikkimk
and
zeroedin
authored
feat(dropdown): prop updated to match upstream api
Nikki Massaro Kauffman
committed
Merge branch 'issue-2049' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
Merge branch 'issue-2049' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
feat(chip): increased target size for a11y
Nikki Massaro Kauffman
committed
feat(dropdown): increased target size for a11y
Nikki Massaro Kauffman
committed
feat(select): increased target size for a11y
Nikki Massaro Kauffman
committed
fix(select): fixed PfIcon import

nikkimk
and
zeroedin
authored
fix(select): updated imports

nikkimk
and
zeroedin
authored
fix(select): organized imports

nikkimk
and
zeroedin
authored
fix(select): refactor of options list
Nikki Massaro Kauffman
committed

Commits on Sep 12, 2023

docs(dropdown): updated separator in docs
Nikki Massaro Kauffman
committed
feat(core): init toggle-controller
Nikki Massaro Kauffman
committed

Commits on Sep 13, 2023

feat(dropdown): updated dropdown to use toggle controller
Nikki Massaro Kauffman
committed
feat(select): updated dropdown to use toggle controller
Nikki Massaro Kauffman
committed
feat(select): updated dropdown to use toggle controller
Nikki Massaro Kauffman
committed
fix(chip): fixed issue with focusing on a chip that is removed
Nikki Massaro Kauffman
committed

Commits on Sep 14, 2023

fix(core): fixed focus on toggle copntroller close
Nikki Massaro Kauffman
committed
fix(dropdown): fixed focus issues with dropdown and tests
Nikki Massaro Kauffman
committed
docs(dropdown): updated docs
Nikki Massaro Kauffman
committed
docs(select): updated docs
Nikki Massaro Kauffman
committed
docs(chip): updated docs
Nikki Massaro Kauffman
committed
fix(core): Updated toggle-controller

nikkimk
and
zeroedin
authored
fix(dropdown): Sorted the #private properties below the decorated

nikkimk
and
zeroedin
authored
docs(core): Updated comment on toggle-controller

nikkimk
and
zeroedin
authored
docs(core): Updated comment typo in toggle-controller

nikkimk
and
zeroedin
authored

Commits on Sep 20, 2023

fix(select): implemented aria-disabled for a11y
Nikki Massaro Kauffman
committed
fix(select): implemented aria-disabled for a11y
Nikki Massaro Kauffman
committed
fix(select): implemented aria-disabled for a11y
Nikki Massaro Kauffman
committed
fix(select): implemented aria-disabled for a11y
Nikki Massaro Kauffman
committed
fix(dropdown): implemented aria-disabled for a11y
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(core): rti updateItems to keep focus on activeItem or next item
Nikki Massaro Kauffman
committed
fix(chip): fixed chip group keyboard nav and long chip vertical alignment
Nikki Massaro Kauffman
committed
fix(dropdown): updated a11y keyboard navigation
Nikki Massaro Kauffman
committed

Commits on Sep 21, 2023

feat(core): controller formatting
Nikki Massaro Kauffman
committed
fix(chip): formatting
Nikki Massaro Kauffman
committed
fix(dropdown): formatting
Nikki Massaro Kauffman
committed
fix(select): formatting
Nikki Massaro Kauffman
committed
feat(core): moved nav by first char form listbox controller to roving tabindex controller
Nikki Massaro Kauffman
committed
Merge branch 'main' into menu-dropdown-listbox
nikkimk
authored
Updated changeset rh-listbox-elements.md
nikkimk
authored
Delete outdated .changeset/pf-dropdown.md
nikkimk
authored
docs(dropdown): removed unused value property
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed

Commits on Sep 26, 2023

fix(dropdown): updated test based on correct a11y
Nikki Massaro Kauffman
committed

Commits on Sep 28, 2023

test(dropdown): fixed test
Nikki Massaro Kauffman
committed

Commits on Oct 4, 2023

fix(core): fixes issue where tabindex is not updated when rti items are updated
Nikki Massaro Kauffman
committed
fix(chip): removes chips without buttons from rti updates
Nikki Massaro Kauffman
committed
fix(core): fixed issue with listbox controller preventing selection
Nikki Massaro Kauffman
committed
fix(select): fixed issue with setting aria-disabled
Nikki Massaro Kauffman
committed
docs(chip): added screenshot
Nikki Massaro Kauffman
committed
docs(dropdown): updated screenshot
Nikki Massaro Kauffman
committed
docs(select): updated screenshot
Nikki Massaro Kauffman
committed
feat(core): updated toggle controler event handlers
Nikki Massaro Kauffman
committed
fix(core): updating rti items should not set focus unless host already has focus
Nikki Massaro Kauffman
committed
docs(chip): fixed typo in comment
Nikki Massaro Kauffman
committed
test(chip): moved a11y test on its own
Nikki Massaro Kauffman
committed

Commits on Oct 5, 2023

fix(select): chip group should not be removable
Nikki Massaro Kauffman
committed
test(select): removed unneccesary waits
Nikki Massaro Kauffman
committed
test(select): fixed tests
Nikki Massaro Kauffman
committed
fix(select): fixes input toggling
Nikki Massaro Kauffman
committed
fix(select): fixed typeahead toggle
Nikki Massaro Kauffman
committed

Commits on Oct 15, 2023

refactor(core): rename internal type
bennypowers
committed

Commits on Oct 16, 2023

feat(chip): updated changeset
Nikki Massaro Kauffman
committed
feat(dropdown): updated changeset
Nikki Massaro Kauffman
committed
feat(select): updated changeset and fixed API based on feedback
Nikki Massaro Kauffman
committed
feat(core): updated changeset
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed

Commits on Oct 17, 2023

fix(select): refactor aria-disabled
Nikki Massaro Kauffman
committed

Commits on Oct 18, 2023

fix(select): refactored based on review, updated disabled and multiselectable
Nikki Massaro Kauffman
committed
fix(core): moved order of event key handling in listbox-controller
Nikki Massaro Kauffman
committed
Merge branch 'main' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(core): refactored listbox-controller based on feedback
Nikki Massaro Kauffman
committed
Merge branch 'main' into menu-dropdown-listbox
bennypowers
authored
fix(core): updated listbox controller based on feedback
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(core): updated toggle-controler based on feedback
Nikki Massaro Kauffman
committed
fix(chip): updated chip, chip group and docs based
Nikki Massaro Kauffman
committed
fix(chip): updated has-category
Nikki Massaro Kauffman
committed
docs(chip): updated docs references to accessible instead of ARIA
Nikki Massaro Kauffman
committed
fix(chip): removed overflow-hidden attribute from chip
Nikki Massaro Kauffman
committed
fix(chip): updated chip events
Nikki Massaro Kauffman
committed
fix(select): cleaned up properties and styles
Nikki Massaro Kauffman
committed
fix(core): updated toggle controller to accept current id or generate one
Nikki Massaro Kauffman
committed
fix(select): updated based on feedback
Nikki Massaro Kauffman
committed

Commits on Oct 20, 2023

fix(core): toggle-controller updated random id assignmenrt
Nikki Massaro Kauffman
committed

Commits on Oct 23, 2023

fix(select): updating select based on feedback
Nikki Massaro Kauffman
committed
Merge branch 'main' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(select): fixes filtering
Nikki Massaro Kauffman
committed
fix(select): updated API based on feedback
Nikki Massaro Kauffman
committed

Commits on Oct 24, 2023

fix(select): removed unnecessary connected callback
Nikki Massaro Kauffman
committed
fix(core): Updated .changeset/roving-tabindex-controller.md

nikkimk
and
bennypowers
authored
fix(chip): refactor of hiding overflow chips

nikkimk
and
bennypowers
authored
fix(chip): focus delegation
Nikki Massaro Kauffman
committed
fix(dropdown): focus delegation
Nikki Massaro Kauffman
committed
fix(core): made internals, rti, listbox and toggle controllers singletons
Nikki Massaro Kauffman
committed
docs(chip): updated changeset
Nikki Massaro Kauffman
committed
docs(dropdown): updated changeset
Nikki Massaro Kauffman
committed
docs(select): updated changeset
Nikki Massaro Kauffman
committed
docs(chip): made demo imports inline and split chip-group demos
Nikki Massaro Kauffman
committed
docs(chip): removed wrapping div fromd emos
Nikki Massaro Kauffman
committed
fix(chip): renamed closeLabel to accessibleCloseLabel
Nikki Massaro Kauffman
committed
fix(popover): deprecating close-label and implementing accessible-close-label
Nikki Massaro Kauffman
committed
fix(chip): made button private and fixed demos
Nikki Massaro Kauffman
committed
fix(chip): removed composed from chip events
Nikki Massaro Kauffman
committed
fix(chip): updated readonly property and cleaned up slot
Nikki Massaro Kauffman
committed

Commits on Oct 25, 2023

fix(chip): updated tests
Nikki Massaro Kauffman
committed
test(chip): updated chip-group test
Nikki Massaro Kauffman
committed
test(chip): updated chip-group test

nikkimk
and
bennypowers
authored
test(chip): updating chip tests
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
test(chip): updated tests
Nikki Massaro Kauffman
committed
fix(dropdown): updated dropdown based on feedback
Nikki Massaro Kauffman
committed
fix(dropdown): updated dropdown based on feedback
Nikki Massaro Kauffman
committed
docs(dropdown): updated readme
Nikki Massaro Kauffman
committed

Commits on Oct 26, 2023

fix(dropdown): refactoring to make us of intenrals if available
Nikki Massaro Kauffman
committed
fix(select): working on using internals if available
Nikki Massaro Kauffman
committed
fix(core): working on internals controller as a singleton
Nikki Massaro Kauffman
committed
fix(core): updated because there can be more than one toggle controller
Nikki Massaro Kauffman
committed
test(dropdown): updating tests
Nikki Massaro Kauffman
committed
fix(core): ensure there is a role set on toggle
Nikki Massaro Kauffman
committed
fix(dropdown): attempting to use internals when possible
Nikki Massaro Kauffman
committed
test(dropdown): updated based on feeddback
Nikki Massaro Kauffman
committed
fix(core): updated toggle controller to remove forcing a role
Nikki Massaro Kauffman
committed
fix(dropdown): added missed import
Nikki Massaro Kauffman
committed
test(dropdown): fixed tests
Nikki Massaro Kauffman
committed

Commits on Oct 27, 2023

docs(select): split demos and inline scripts
Nikki Massaro Kauffman
committed
fix(select): refactoring create option and updating checkbox attribute
Nikki Massaro Kauffman
committed

Commits on Nov 1, 2023

docs(select): updated demos
Nikki Massaro Kauffman
committed
fix(select): refactored create option
Nikki Massaro Kauffman
committed
fix(select): updated disabled styling
Nikki Massaro Kauffman
committed
Merge branch 'main' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
Merge branch 'main' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(select): resolved arrowDown toggling
Nikki Massaro Kauffman
committed
fix(select): remove pf-select-list and pf-select-option to pf-listbox and pf-option
Nikki Massaro Kauffman
committed
docs(chip): fixed typos
Nikki Massaro Kauffman
committed
docs(dropdown): fixed typos
Nikki Massaro Kauffman
committed
docs(dropdown): fixed typos
Nikki Massaro Kauffman
committed
docs(core): fixed typos in listbox controller
Nikki Massaro Kauffman
committed
docs(chip): fixed typos
Nikki Massaro Kauffman
committed

Commits on Nov 2, 2023

docs(dropdown): wai-aria disabled complex components snippet
Nikki Massaro Kauffman
committed
docs(select): wai-aria disabled complex components snippet
Nikki Massaro Kauffman
committed
docs(select): updating formatting
Nikki Massaro Kauffman
committed
feat(select): renaming option, listbox, and option group
Nikki Massaro Kauffman
committed
fix(select): updated pf-listbox and controller
Nikki Massaro Kauffman
committed
fix(core): removed unnecessary || undefined from tri's nextMatchingItem
Nikki Massaro Kauffman
committed
test(chip): remove shadowRoot query in favor of a11y snapshot
Nikki Massaro Kauffman
committed
fix(chip): fixed keyboard navigation
Nikki Massaro Kauffman
committed
fix(chip): fixed focus issue when removing a chip
Nikki Massaro Kauffman
committed

Commits on Nov 3, 2023

fix(chip): fixed keyboard navigation and updated tests
Nikki Massaro Kauffman
committed
fix(popover): added changeset
Nikki Massaro Kauffman
committed
test(chip): fixed describe messages
Nikki Massaro Kauffman
committed
test(dropdown): fixed describe messages
Nikki Massaro Kauffman
committed
test(chip): cleaned up chip descriptions
Nikki Massaro Kauffman
committed
test(dropdown): cleaned up descriptions
Nikki Massaro Kauffman
committed
test(select): cleaned up descriptions
Nikki Massaro Kauffman
committed
docs(chip): updated demos
Nikki Massaro Kauffman
committed
docs(dropdown): updated demos and docs
Nikki Massaro Kauffman
committed
docs(select): updated demos
Nikki Massaro Kauffman
committed
fix(chip): removed aria-labelled by on overflow chip
Nikki Massaro Kauffman
committed
test(select): fixes tests
Nikki Massaro Kauffman
committed
fix(chip): updated based on feedback and added more documentaiton
Nikki Massaro Kauffman
committed
fix(core): updated toggle-controller based on feedback
Nikki Massaro Kauffman
committed
fix(select): updated based on feedback
Nikki Massaro Kauffman
committed
docs(chip): updated JSDoc for events
Nikki Massaro Kauffman
committed
docs(select): updated JSDoc for events
Nikki Massaro Kauffman
committed
Merge branch 'main' into menu-dropdown-listbox
nikkimk
authored

Commits on Nov 6, 2023

docs: changeset
bennypowers
committed
style: white space and import order
bennypowers
committed
style(select): whitespace, template
bennypowers
committed
fix(dropdown): formatting, event
bennypowers
committed
fix(core): rti types
bennypowers
committed
chore: build order
bennypowers
committed
fix(core): internalscontroller aria mixin props
bennypowers
committed
fix(core): make controllers framework-friendly
bennypowers
committed
style(dropdown): whitespace
bennypowers
committed
docs(chip): demos
bennypowers
committed
fix(chip): events
bennypowers
committed
refactor(chip): type names
bennypowers
committed
fix(chip): updated overflow and label properties based on feedback
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
fix(chip): updated chip group
Nikki Massaro Kauffman
committed
fix(core): removed this.host.expanded from toggle controller
Nikki Massaro Kauffman
committed
fix(dropdown): removed unncessary `expanded` property
Nikki Massaro Kauffman
committed
fix(dropdown): removed unncessary `expanded` property
Nikki Massaro Kauffman
committed

Commits on Nov 7, 2023

Commits on Nov 16, 2023

Merge branch 'main' into menu-dropdown-listbox
nikkimk
authored

Commits on Nov 21, 2023

chore: sync package lock
bennypowers
committed

Commits on Nov 28, 2023

fix: revert dev command changes
zeroedin
committed

Commits on Nov 30, 2023

fix(chip): now more overflow-chip styles not needed
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed

Commits on Jan 15, 2024

Merge branch 'main' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed

Commits on Jan 18, 2024

fix: replace activedescendant with tabindex controller
bennypowers
committed
refactor: rename internalscontroller static constructor
bennypowers
committed
Merge branch 'main' into menu-dropdown-listbox
bennypowers
committed
fix: lint and type errors
bennypowers
committed
chore: update deps
bennypowers
committed
fix: avoid ts meltdown
bennypowers
committed
fix(core): types for Logger
bennypowers
committed
fix: types for css files
bennypowers
committed
fix: typescript stuff
bennypowers
committed
chore: make lit/react a devDep
bennypowers
committed
chore: wrangle package lock
bennypowers
committed
test(select): normalize some tests
bennypowers
committed
feat(chip): reverted from pf-button to button and updated styles
Nikki Massaro Kauffman
committed
fix(chip): correcting non pfv4 tokens

zeroedin
authored and
bennypowers
committed
fix(dropdown): correcting non pfv4 tokens

zeroedin
authored and
bennypowers
committed
fix(select): correcting non pfv4 tokens

zeroedin
authored and
bennypowers
committed
fix(select): correcting non pfv4 tokens

zeroedin
authored and
bennypowers
committed
fix(select): use non dark version of token instead

zeroedin
authored and
bennypowers
committed
fix(select): correct typo

zeroedin
authored and
bennypowers
committed
refactor: remove ListboxControllerItem interface
bennypowers
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
Merge branch 'menu-dropdown-listbox' of github.com:patternfly/patternfly-elements into menu-dropdown-listbox
Nikki Massaro Kauffman
committed
test(select): fix more tests
bennypowers
committed
fix(chip): updated target size to WCAG AA 24px
Nikki Massaro Kauffman
committed
fix(select): fixed listbox selection
Nikki Massaro Kauffman
committed

Commits on Jan 19, 2024