Skip to content

fix(expandable section): Fix uncaught exception #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 1 commit into from
Jul 8, 2024
Merged

fix(expandable section): Fix uncaught exception #10659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,12 @@ class ExpandableSection extends React.Component<ExpandableSectionProps, Expandab
};

resize = () => {
const { offsetWidth } = this.expandableContentRef.current;
if (this.state.previousWidth !== offsetWidth) {
this.setState({ previousWidth: offsetWidth });
this.checkToggleVisibility();
if (this.expandableContentRef) {
const { offsetWidth } = this.expandableContentRef.current;
Comment on lines +174 to +175

@christianvogt christianvogt Jul 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix work?
this.expandableContentRef is assigned as a class property:
expandableContentRef = React.createRef<HTMLDivElement>();
Therefore this.expandableContentRef is always an object. However expandableContentRef.current may be null.

Therefore shouldn't the fix be:

if (this.expandableContentRef.current) {

@tlabaj tlabaj Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. when i originally pushed a change i had a check to current that is missing here. I will push nother fix so it is included in our up coming release.

if (this.state.previousWidth !== offsetWidth) {
this.setState({ previousWidth: offsetWidth });
this.checkToggleVisibility();
}
}
};
handleResize = debounce(this.resize, 250);
Expand Down