chore(Alert): updated examples to enable animations#11705
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11705.surge.sh A11y report: https://patternfly-react-pr-11705-a11y.surge.sh |
edonehoo
reviewed
Mar 21, 2025
| import LaptopIcon from '@patternfly/react-icons/dist/esm/icons/laptop-icon'; | ||
| import buttonStyles from '@patternfly/react-styles/css/components/Button/button'; | ||
|
|
||
| Micro-animations have been added for `Alert` components within an `AlertGroup`, which can be seen on all examples and demos where alerts are dynamically added. By default this is opt-in, as enabling animations may require updates to tests. You can pass the `hasAnimations` property to enable or disable the animations as needed. Additionally, with these animations enabled, we recommend you ensure that dynamically added alerts are prepended to a list of alerts, rather than appended to the end of it. |
Contributor
There was a problem hiding this comment.
Suggested change
| Micro-animations have been added for `Alert` components within an `AlertGroup`, which can be seen on all examples and demos where alerts are dynamically added. By default this is opt-in, as enabling animations may require updates to tests. You can pass the `hasAnimations` property to enable or disable the animations as needed. Additionally, with these animations enabled, we recommend you ensure that dynamically added alerts are prepended to a list of alerts, rather than appended to the end of it. | |
| Micro animations have been added for `<Alert>` components within an `<AlertGroup>`. By default, you must opt into animations, since they can require updates to tests. To enable or disable animations as needed, use the `hasAnimations` property. With animations enabled, we recommend you ensure that dynamically-added alerts are prepended to a list of alerts, rather than appended to the end of it. | |
| Micro animations are turned on for all examples and demos where alerts are dynamically added. |
just a little moving things around mainly. I think it makes sense to include this for alert, since we have motion in all examples even though its opt in!
kmcfaul
approved these changes
Mar 26, 2025
Contributor
|
One minor thing I noticed which can be left as is or explored in a follow up is that in the timeout alert example, if you manually dismiss the alert with the button instead of letting it time out the close animation doesn't play. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11684
@edonehoo @andrew-ronaldson wdyt about the verbiage above the examples? More or less using the copy from the release highlights, but curious if you think it's worth including/helpful here.
Additional issues: