Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 1#12501

Merged
kmcfaul merged 1 commit into
patternfly:mainfrom
thatblindgeye:iss12399_part1
Jun 23, 2026
Merged

fix(InfrastructureIcons): replaced with RH brand icons part 1#12501
kmcfaul merged 1 commit into
patternfly:mainfrom
thatblindgeye:iss12399_part1

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

This covers ServerIcon, StorageDomainIcon, and LayerGroupIcon

Additional issues:

Summary by CodeRabbit

  • Chores
    • Updated icons used in Alert, Menu (including drilldown), Tabs, and CustomMenus examples/demos to newer PatternFly variants. Replaced older server/storage/layer-group icons (and related imports) with RhUiServerStackFillIcon and RhUiStorageDomainFillIcon where appropriate. Also refreshed the Menu demo in the integration app to match. No component behavior or interactions changed.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f0adee2-064d-4c45-a06d-716e375edce0

📥 Commits

Reviewing files that changed from the base of the PR and between 224c5b5 and bd96bbd.

📒 Files selected for processing (14)
  • packages/react-core/src/components/Alert/examples/Alert.md
  • packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldown.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownSubmenuFunctions.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithIcons.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/CustomMenus/examples/DrilldownMenuDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDrilldownDemo.tsx
✅ Files skipped from review due to trivial changes (12)
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldown.tsx
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/Alert/examples/Alert.md
  • packages/react-core/src/demos/CustomMenus/examples/DrilldownMenuDemo.tsx
  • packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithIcons.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownSubmenuFunctions.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDrilldownDemo.tsx
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx

Walkthrough

Across Alert, Tabs, Menu, and CustomMenus example and integration demo files, icon imports and usages are updated: ServerIcon is replaced with RhUiServerStackFillIcon, and StorageDomainIcon and LayerGroupIcon are replaced with RhUiStorageDomainFillIcon and RhUiServerStackFillIcon respectively.

Changes

Icon Replacements in Examples and Demos

Layer / File(s) Summary
Alert and Tabs icon swap
packages/react-core/src/components/Alert/examples/Alert.md, packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx, packages/react-core/src/components/Tabs/examples/Tabs.md, packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx
Replaces ServerIcon with RhUiServerStackFillIcon in both the markdown import declarations and TSX component renders for the Alert and Tabs examples.
Menu examples icon swap
packages/react-core/src/components/Menu/examples/Menu.md, packages/react-core/src/components/Menu/examples/MenuWithIcons.tsx, packages/react-core/src/components/Menu/examples/MenuWithDrilldown.tsx, packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx, packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx, packages/react-core/src/components/Menu/examples/MenuWithDrilldownSubmenuFunctions.tsx
Replaces StorageDomainIcon and LayerGroupIcon with RhUiStorageDomainFillIcon and RhUiServerStackFillIcon in the icons-only menu and all four drilldown Menu example files, updating both imports and JSX icon props.
CustomMenus demo icon swap
packages/react-core/src/demos/CustomMenus/CustomMenus.md, packages/react-core/src/demos/CustomMenus/examples/DrilldownMenuDemo.tsx
Replaces StorageDomainIcon and LayerGroupIcon with RhUiStorageDomainFillIcon and RhUiServerStackFillIcon in the CustomMenus demo markdown and the DrilldownMenuDemo storage drilldown menu.
Integration demo icon swap
packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDrilldownDemo.tsx
Applies the same icon substitutions to the integration test demo app's Menu and MenuDrilldown demo components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • patternfly/patternfly-react#12401: The main tracking issue for icon replacement work that this PR directly addresses by swapping legacy PatternFly icons with RH brand equivalents across examples and demos.

Possibly related PRs

  • patternfly/patternfly-react#12482: Also swaps ServerIcon for RhUiServerStackFillIcon in Alert and Tabs example files, following the same icon modernization pattern.

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • phcox
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing Infrastructure icons with Red Hat brand icons across multiple components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs rebase!

@kmcfaul kmcfaul merged commit a479b4c into patternfly:main Jun 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants