Skip to content

fix(table): updated nested sticky header example with isBorderRow tr #12527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmcfaul merged 2 commits into from
Jun 25, 2026
+85 −79
Merged

fix(table): updated nested sticky header example with isBorderRow tr #12527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d09b88
fix(table): updated nested sticky header example with isBorderRow tr
mcoker Jun 25, 2026
ef54927
chore: removed random slash
mcoker Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-table/src/components/Table/examples/Table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ To make a nested column header:
2. Pass `nestedHeaderColumnSpans` to `Table`. `nestedHeaderColumnSpans` is an array of numbers representing the column spans of the top level columns to `Table`, where each number is equal to the number of sub columns for a column, or `1` if a column contains no sub columns.
3. Pass `hasNestedHeader` to `Thead`.
4. Pass two `Tr` as children of `Thead`.
5. If the parent `Table` has a sticky header, pass an additional `Tr isBorderRow` in `Thead` to create the bottom border in the `Thead`.

The first `Tr` represents the top level of columns, and each must pass either `rowSpan` if the column does not contain sub columns or `colSpan` if the column contains sub columns. The value of `rowSpan` is equal to the number of rows the nested header will span, typically `2`, and the value of `colSpan` is equal to the number of sub columns in a column. Each `Th` except the last should also pass `hasRightBorder`.

Expand Down
163 changes: 84 additions & 79 deletions packages/react-table/src/components/Table/examples/TableNestedStickyHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,85 +112,90 @@ export const TableNestedHeaders: React.FunctionComponent = () => {
});

return (
<InnerScrollContainer>
<Table aria-label="Nested column headers table" gridBreakPoint="" isStickyHeader>
<Thead hasNestedHeader>
<Tr>
<Th hasRightBorder colSpan={3}>
{columnNames.pods}
</Th>
<Th hasRightBorder colSpan={2}>
{columnNames.ports}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(5)}>
{columnNames.protocol}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(6)}>
{columnNames.flowRate}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(7)}>
{columnNames.traffic}
</Th>
<Th modifier="fitContent" rowSpan={2} sort={getSortParams(8)}>
{columnNames.packets}
</Th>
</Tr>
<Tr>
<Th isSubheader sort={getSortParams(0)}>
{columnNames.source}
</Th>
<Th isSubheader sort={getSortParams(1)}>
{columnNames.destination}
</Th>
<Th isSubheader modifier="fitContent" hasRightBorder sort={getSortParams(2)}>
{columnNames.datetime}
</Th>
<Th isSubheader modifier="fitContent" sort={getSortParams(3)}>
{columnNames.source}
</Th>
<Th isSubheader modifier="fitContent" hasRightBorder sort={getSortParams(4)}>
{columnNames.destination}
</Th>
</Tr>
</Thead>
<Tbody>
{sortedConnections.map((connection) => (
<Tr key={connection.source.podName}>
<Td dataLabel={columnNames.source}>{connection.source.podName}</Td>
<Td dataLabel={columnNames.destination}>{connection.destination.podName}</Td>\
<Td dataLabel={columnNames.datetime}>
<div>
<Timestamp dateFormat="full" timeFormat="medium" date={new Date(connection.timestamp)} />
</div>
</Td>
<Td dataLabel={columnNames.source}>
<Stack>
<StackItem>
<span>{connection.source.port.num}</span>
</StackItem>
<StackItem>
<small>({connection.source.port.protocol})</small>
</StackItem>
</Stack>
</Td>
<Td dataLabel={columnNames.destination}>
<Stack>
<StackItem>
<span>{connection.destination.port.num}</span>
</StackItem>
<StackItem>
<small>({connection.destination.port.protocol})</small>
</StackItem>
</Stack>
</Td>
<Td dataLabel={columnNames.protocol}>{connection.protocol}</Td>
<Td dataLabel={columnNames.flowRate}>{connection.flowRate}</Td>
<Td dataLabel={columnNames.traffic}>{connection.traffic}</Td>
<Td dataLabel={columnNames.packets}>{connection.packets}</Td>
<div style={{ height: '250px' }}>
<InnerScrollContainer>
<Table aria-label="Nested column headers table" gridBreakPoint="" isStickyHeader>
<Thead hasNestedHeader>
<Tr>
<Th hasRightBorder colSpan={3}>
{columnNames.pods}
</Th>
<Th hasRightBorder colSpan={2}>
{columnNames.ports}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(5)}>
{columnNames.protocol}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(6)}>
{columnNames.flowRate}
</Th>
<Th modifier="fitContent" hasRightBorder rowSpan={2} sort={getSortParams(7)}>
{columnNames.traffic}
</Th>
<Th modifier="fitContent" rowSpan={2} sort={getSortParams(8)}>
{columnNames.packets}
</Th>
</Tr>
))}
</Tbody>
</Table>
</InnerScrollContainer>
<Tr>
<Th isSubheader sort={getSortParams(0)}>
{columnNames.source}
</Th>
<Th isSubheader sort={getSortParams(1)}>
{columnNames.destination}
</Th>
<Th isSubheader modifier="fitContent" hasRightBorder sort={getSortParams(2)}>
{columnNames.datetime}
</Th>
<Th isSubheader modifier="fitContent" sort={getSortParams(3)}>
{columnNames.source}
</Th>
<Th isSubheader modifier="fitContent" hasRightBorder sort={getSortParams(4)}>
{columnNames.destination}
</Th>
</Tr>
<Tr isBorderRow aria-hidden="true">
<Td colSpan={9}></Td>
</Tr>
</Thead>
<Tbody>
{sortedConnections.map((connection) => (
<Tr key={connection.source.podName}>
<Td dataLabel={columnNames.source}>{connection.source.podName}</Td>
<Td dataLabel={columnNames.destination}>{connection.destination.podName}</Td>
<Td dataLabel={columnNames.datetime}>
<div>
<Timestamp dateFormat="full" timeFormat="medium" date={new Date(connection.timestamp)} />
</div>
</Td>
<Td dataLabel={columnNames.source}>
<Stack>
<StackItem>
<span>{connection.source.port.num}</span>
</StackItem>
<StackItem>
<small>({connection.source.port.protocol})</small>
</StackItem>
</Stack>
</Td>
<Td dataLabel={columnNames.destination}>
<Stack>
<StackItem>
<span>{connection.destination.port.num}</span>
</StackItem>
<StackItem>
<small>({connection.destination.port.protocol})</small>
</StackItem>
</Stack>
</Td>
<Td dataLabel={columnNames.protocol}>{connection.protocol}</Td>
<Td dataLabel={columnNames.flowRate}>{connection.flowRate}</Td>
<Td dataLabel={columnNames.traffic}>{connection.traffic}</Td>
<Td dataLabel={columnNames.packets}>{connection.packets}</Td>
</Tr>
))}
</Tbody>
</Table>
</InnerScrollContainer>
</div>
);
};
Loading