chore(Checkbox): updated example CSS to use logical property#9604
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9604.surge.sh A11y report: https://patternfly-react-pr-9604-a11y.surge.sh |
mcoker
approved these changes
Sep 12, 2023
| @@ -1,3 +1,3 @@ | |||
| .ws-react-c-checkbox .pf-v5-c-check.nested { | |||
| padding-left: var(--pf-v5-global--spacer--md); | |||
| padding-inline-start: var(--pf-v5-global--spacer--md); | |||
Contributor
There was a problem hiding this comment.
LGTM - though instead of the custom nested class, we could put the children in a check body, which I think is how we recommend nested/children inputs to display. wdyt?
wise-king-sullyman
approved these changes
Sep 12, 2023
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
Collaborator
There was a problem hiding this comment.
Agree with @mcoker but also don't think it's worth blocking over.
thatblindgeye
force-pushed
the
iss9590
branch
from
a87a9b0 to
62b44a3
Compare
tlabaj
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9590
Additional issues: