Skip to content

Fixing Kafka Default configuration merge - #561

Closed
adumas37 wants to merge 2 commits into
php-enqueue:masterfrom
adumas37:patch-1
Closed

adumas37 wants to merge 2 commits into
php-enqueue:masterfrom
adumas37:patch-1

Conversation

@adumas37

@adumas37 adumas37 commented Oct 16, 2018 •

Copy link
Copy Markdown
Contributor

Fixing the constructor to merge recursively default config and user config.

@makasim

makasim commented Oct 16, 2018

Copy link
Copy Markdown
Member

@adumas37 thank you! Could you add a test?

@makasim makasim added the bug label Oct 16, 2018
@makasim

makasim commented Oct 16, 2018

Copy link
Copy Markdown
Member

@adumas37 are you find with merging it into master (which is 0.9.x-dev)?

@adumas37

Copy link
Copy Markdown
Contributor Author

I need it in my current project as soon as possible, so yes :)

@makasim

makasim commented Oct 16, 2018

Copy link
Copy Markdown
Member

Do you use a dev version? or stable 0.8.x?

@adumas37

Copy link
Copy Markdown
Contributor Author

According to my composer.lock i'm using the stable version :

"name": "enqueue/enqueue-bundle",
"version": "0.8.37"

@makasim
makasim changed the base branch from master to 0.8 October 16, 2018 13:52
@makasim
makasim changed the base branch from 0.8 to master October 16, 2018 13:52
@makasim

makasim commented Oct 16, 2018

Copy link
Copy Markdown
Member

@adumas37 could you please cherry pick it and opened agains 0.8 branch?

@makasim makasim closed this Oct 16, 2018
@makasim makasim added this to the 0.9 milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants