Skip to content

Adds editor configs - #4

Open
NickSdot wants to merge 2 commits into
php:masterfrom
NickSdot:add-editorconfig
Open

NickSdot wants to merge 2 commits into
php:masterfrom
NickSdot:add-editorconfig

Conversation

@NickSdot

@NickSdot NickSdot commented Sep 5, 2026

Copy link
Copy Markdown

Adds the same .editorconfig as in doc-en so XML files are aligned in all repos. Also adds .gitattributes so Git normalises text files to LF.

@alfsb

alfsb commented Sep 5, 2026

Copy link
Copy Markdown
Member

In translations, trim_trailing_whitespace = true is worth the trouble.

@NickSdot

NickSdot commented Sep 5, 2026

Copy link
Copy Markdown
Author

In translations, trim_trailing_whitespace = true is worth the trouble.

Can set it true if you want. Here or everywhere?

Edit: why I ask here or everywhere is because I opened this in multiple languages. So I would like to know if your comment "go with trim_trailing_whitespace = true" applies to all repos.

Not sure how your translations workflows look like, but wouldn't that require doc-en to be the same? Also worth to mention: docbook-cs has an auto-fixer for that now.

@alfsb

alfsb commented Sep 5, 2026

Copy link
Copy Markdown
Member

In translations, trim_trailing_whitespace = true is worth the trouble.

Can set it true if you want. Here or everywhere?

Not sure how your translations workflows look like, but wouldn't that require doc-en to be the same? Also worth to mention: docbook-cs has an auto-fixer for that now.

Whereas I would want it set as true everywhere, this was considered and rejected in doc-en in the past, as it would cause changes in "unrelated" lines, and diffs is used on translations. So translations can have it set as true, but until doc-en is mass trimmed (and commited with skip-revcheck), this is not a change to be decided without further consideration.

After all, there are about 3260 files with trailnig spaces in doc-en, about 30% of all XML files...

@NickSdot

NickSdot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants