Fix Zend/zend_simd.h file whitespaces sync#20486
Merged
Merged
Conversation
Contributor
Author
|
Hi @SakiTakamachi, can you review this PR? |
Contributor
Author
|
It seems Saki is not active recently, can someone else please verify correctness of this PR (WS changes) and merge it? |
Contributor
Author
|
@ndossche can you review please? |
ndossche
approved these changes
Dec 7, 2025
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Verified by pulling this locally and replacing the file with upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #19802
All changes are whitespaces, they can be verified by diffing replaced file before/after after replacing spaces with nothing (empty string).
The file was introduced in #18413 from https://github.com/SakiTakamachi/xsse/blob/xsse-1.0.0/src/xsse.h.