perf: direct syscall fastpath for absolute paths in zend_virtual_cwd#22722
Open
henderkes wants to merge 1 commit into
Open
perf: direct syscall fastpath for absolute paths in zend_virtual_cwd#22722henderkes wants to merge 1 commit into
henderkes wants to merge 1 commit into
Conversation
staabm
reviewed
Jul 14, 2026
|
|
||
| #ifndef ZEND_WIN32 | ||
| if (virtual_path_is_direct(path)) { | ||
| return fopen(path, mode); |
Contributor
There was a problem hiding this comment.
should this use php_win32_ioutil_fopen on windows?
Contributor
There was a problem hiding this comment.
ohh its ifNdef ZEND_WIN32 .. nevermind
Contributor
Author
There was a problem hiding this comment.
yeah, I will revisit all these small findings later on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolute paths don't need to go through the per-thread cwd emulation, add a fast-path to directly hand them to libc.
since relative paths won't start with a leading slash, this adds negligible cost for them