Skip to content

CI: fix template-injection findings in GitHub Actions workflows #22732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgsowa wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+19 −6
Open

CI: fix template-injection findings in GitHub Actions workflows #22732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/nightly-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ jobs:
runs-on: ubuntu-latest
if: ${{ github.repository == 'php/php-src' && github.event.workflow_run.event == 'schedule' && github.event.workflow_run.conclusion == 'failure' }}
steps:
- run: |
- env:
RUN_URL: ${{ github.event.workflow_run.html_url }}
SLACK_WEBHOOK: ${{ secrets.ACTION_MONITORING_SLACK }}
run: |
export DEBIAN_FRONTEND=noninteractive
sudo apt-get install -y curl
curl -X POST -H 'Content-type: application/json' --data '{"attachments": [{"text": "Job(s) in *nightly* failed", "footer": "<${{ github.event.workflow_run.html_url }}|View Run>", "color": "danger", "mrkdwn_in": ["text"]}]}' ${{ secrets.ACTION_MONITORING_SLACK }}
curl -X POST -H 'Content-type: application/json' --data "$(printf '{"attachments": [{"text": "Job(s) in *nightly* failed", "footer": "<%s|View Run>", "color": "danger", "mrkdwn_in": ["text"]}]}' "$RUN_URL")" "$SLACK_WEBHOOK"
8 changes: 6 additions & 2 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,10 @@ jobs:
exit $X
- name: Test Laravel
if: ${{ !cancelled() }}
env:
LARAVEL_VERSION: ${{ fromJson(inputs.branch).jobs.COMMUNITY.config.laravel_version }}
run: |
branch=${{ fromJson(inputs.branch).jobs.COMMUNITY.config.laravel_version }}
branch="$LARAVEL_VERSION"
git clone https://github.com/laravel/framework.git --depth=1 ${branch:+--branch="$branch"}
cd framework
git rev-parse HEAD
Expand Down Expand Up @@ -562,8 +564,10 @@ jobs:
fi
- name: Test Symfony
if: ${{ !cancelled() }}
env:
SYMFONY_VERSION: ${{ fromJson(inputs.branch).jobs.COMMUNITY.config.symfony_version }}
run: |
branch=${{ fromJson(inputs.branch).jobs.COMMUNITY.config.symfony_version }}
branch="$SYMFONY_VERSION"
git clone https://github.com/symfony/symfony.git --depth=1 ${branch:+--branch="$branch"}
cd symfony
git rev-parse HEAD
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ jobs:
nightly-
- name: Generate Matrix
id: set-matrix
run: php .github/matrix.php "${{ github.event_name }}" "${{ github.run_attempt }}" "${{ github.event_name == 'pull_request' && github.ref || github.ref_name }}" '${{ toJSON(github.event.pull_request.labels) }}' "${{ github.repository }}"
env:
EVENT_NAME: ${{ github.event_name }}
RUN_ATTEMPT: ${{ github.run_attempt }}
REF: ${{ github.event_name == 'pull_request' && github.ref || github.ref_name }}

@TimWolla TimWolla Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but this could use the case() function.

PR_LABELS: ${{ toJSON(github.event.pull_request.labels) }}
REPOSITORY: ${{ github.repository }}
run: php .github/matrix.php "$EVENT_NAME" "$RUN_ATTEMPT" "$REF" "$PR_LABELS" "$REPOSITORY"
TEST:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ jobs:
- name: Build
env:
GITHUB_TOKEN: ${{ secrets.WINDOWS_BUILDS_TOKEN }}
TAG: ${{ inputs.tag || github.ref_name }}
run: |
TAG="${{ inputs.tag || github.ref_name }}"
gh workflow run php.yml -R php/php-windows-builder -f php-version="${TAG#php-}"
Loading