Fix GH-22214: Honor opcache.dups_fix for duplicate functions - #23625
Open
prateekbhujel wants to merge 1 commit into
Open
Fix GH-22214: Honor opcache.dups_fix for duplicate functions#23625prateekbhujel wants to merge 1 commit into
prateekbhujel wants to merge 1 commit into
Conversation
Member
|
As a bug fix to behavior existing since 8.4, plz target 8.4 instead. |
Check ignore_dups in _zend_accel_function_hash_copy before raising a redeclaration error, matching the existing behavior for classes.
prateekbhujel
force-pushed
the
prateek/gh22214-opcache-dups-fix-functions
branch
from
September 9, 2026 09:16
9887050 to
5c0f515
Compare
Contributor
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes GH-22214.
opcache.dups_fixwas checked when copying the class table in_zend_accel_class_hash_copy, but_zend_accel_function_hash_copyunconditionally raised a fatal error on duplicate functions without checkingignore_dups.This adds the missing check in
_zend_accel_function_hash_copyto ignore duplicate functions whenopcache.dups_fixis enabled, keeping the first definition.