Url builder fixes - #23636
Open
kocsismate wants to merge 7 commits into
Open
Conversation
Reject literal path, query and fragment delimiters before the hostname setter can silently discard the rest of the input.
Populate validation error details when a code is available, and initialize an empty errors array for other builder failures.
Rename the output argument to softErrors and clear it on error-free success. Preserve it on failure while including earlier soft errors in the exception. This makes the behavior consistent with parsing in the constructor.
Reject credentials and ports when a host becomes empty after normalization instead of silently discarding them. Perform validation once, after setting the host.
Keep empty components distinct from null so serialization retains the trailing question mark or hashmark.
Percent-encode only the space immediately preceding a query or fragment delimiter, retaining validation errors for every parsed space.
Preserve absent hosts for non-special URLs and initialize opaque paths directly. Protect path delimiters, report space errors and encode the space immediately before a query or fragment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bugs/incompatibilities were found, each of them are now fixed in a separate commit.