Adding ability to create a DateTime or DateTimeImmutable from an inst…#5016
Adding ability to create a DateTime or DateTimeImmutable from an inst…#5016mikeSimonson wants to merge 6 commits into
Conversation
|
+1 on these methods. Ideally we'd have just added these instead of createFromMutable+createFromImmutable. |
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
I'm OK with this idea, as Mike and I discussed this recently.
|
@mikeSimonson |
mikeSimonson
force-pushed
the
datetime-create-from-interface
branch
from
fbcad83 to
fea4392
Compare
mikeSimonson
force-pushed
the
datetime-create-from-interface
branch
from
fea4392 to
2bbf3d4
Compare
|
As far as I can tell this PR is ready tested and respect the CS ? |
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Looks good to me, but let's wait until Derick has had a look at this as well.
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
LGTM, but please fix the two nits before merging.
| int(1) | ||
| ["timezone"]=> | ||
| string(6) "+01:00" | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: please make sure the last line also has a new line at the end (but not an extra empty line)
| int(1) | ||
| ["timezone"]=> | ||
| string(6) "+01:00" | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: please make sure the last line also has a new line at the end (but not an extra empty line)
|
It seems to me that this PR obsoletes PR #3394. |
5 participants
…ance of the interface