Skip to content

added regression test #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 3 commits into from
Nov 1, 2022
Merged

added regression test #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8528b
added regression test
staabm Nov 1, 2022
38e37b2
added NodeScopeResolverTest
staabm Nov 1, 2022
4093ea7
also assert on variables
staabm Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,8 +1116,8 @@ public function dataFileAsserts(): iterable
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8225.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8242.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/composer-treatPhpDocTypesAsCertainBug.php');

yield from $this->gatherAssertTypes(__DIR__ . '/data/closure-retain-expression-types.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7913.php');
}

/**
Expand Down
25 changes: 25 additions & 0 deletions tests/PHPStan/Analyser/data/bug-7913.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php declare(strict_types = 1);

namespace Bug7913b;

use function PHPStan\Testing\assertType;

const X = [];
assertType('array{}', X);
if (!empty(X)) {
assertType('*NEVER*', X);
foreach (X as $y) {
print($y);
}
}
assertType('array{}', X);

$x = [];
assertType('array{}', $x);
if (!empty($x)) {
assertType('*NEVER*', $x);
foreach ($x as $y) {
print($y);
}
}
assertType('array{}', $x);
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Arrays/DeadForeachRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ public function testRule(): void
]);
}

public function testBug7913(): void
{
$this->analyse([__DIR__ . '/data/bug-7913.php'], []);
}

}
17 changes: 17 additions & 0 deletions tests/PHPStan/Rules/Arrays/data/bug-7913.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php declare(strict_types = 1);

namespace Bug7913;

const X = [];

@staabm staabm Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried wrapping it in a method/function, but using const like in the repro example, only works in top level code, it seems

if (!empty(X)) {
foreach (X as $y) {
print($y);
}
}

$x = [];
if (!empty($x)) {
foreach ($x as $y) {
print($y);
}
}