Skip to content

[2.2.3 perf regression fix] PackageDependencyResolver: memoize resolvePackage per file #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into from
Jul 1, 2026
Merged

[2.2.3 perf regression fix] PackageDependencyResolver: memoize resolvePackage per file #5961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Dependency/PackageDependencyResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ final class PackageDependencyResolver
/** @var array<string, string>|null normalized install path => package name, longest path first */
private ?array $installPathToPackage = null;

/** @var array<string, string|null> file => resolved package (or null for none) */
private array $resolvedPackages = [];

/** @param string[] $composerAutoloaderProjectPaths */
public function __construct(
private array $composerAutoloaderProjectPaths,
Expand All @@ -38,6 +41,19 @@ public function __construct(
}

public function resolvePackage(string $file): ?string
{
// This is called once per dependency file of every analysed file, so the same vendor files
// get resolved over and over. Memoize per file: without it this scans every install path
// (linear in the number of installed packages) on each call, which dominates cold analysis
// of projects with many dependencies.
if (array_key_exists($file, $this->resolvedPackages)) {
return $this->resolvedPackages[$file];
}

return $this->resolvedPackages[$file] = $this->doResolvePackage($file);
}

private function doResolvePackage(string $file): ?string
{
// Normalize with a forward slash regardless of platform: normalizePath() defaults to
// DIRECTORY_SEPARATOR, so on Windows the paths would use '\' while the prefix check below
Expand Down
Loading