Register compiler extensions from attributes instead of an ordered config list

[ondrejmirtes]

The extensions: section of conf/config.neon listed ten compiler extensions whose order was load-bearing but documented nowhere. This removes the section, and first removes the reasons the order mattered.

I permuted the ten extensions and compared the generated containers. Two orderings out of the pairs were genuinely load-bearing, and both are fixed here.

1. #[AutowiredParameter] snapshotted parameter values

processConstructorParameters() resolved %foo% by reading ContainerBuilder::$parameters during loadConfiguration() and baking the value into the definition. ValidateExcludePathsExtension rewrites $parameters['excludePaths'] in its loadConfiguration() (unwrapping OptionalPath objects), so registering autowiredAttributeServices first handed FileExcluderFactory a list of OptionalPath objects:

TypeError: strlen(): Argument #1 ($string) must be of type string, PHPStan\DependencyInjection\Neon\OptionalPath given

References now compile to $this->getParameter('foo') lookups that read the final parameters at service creation time — the representation Nette already emits for dynamic parameters, so %foo.bar% becomes $this->getParameter('foo')['bar'], %foo%/suffix becomes a concatenation, and FactoryDefinition rewrites $this to $this->container inside generated factories. Parameter names cannot change after loadConfiguration(), so a typo in a reference is still reported while compiling.

Over 30 random permutations: 15 died on that TypeError before, all 30 produce byte-identical containers after.

2. Service tags were validated too early

ValidateServiceTagsExtension checked tags in beforeCompile(), but those hooks run in registration order, so it only saw tags added by extensions registered before it. Two cases escaped entirely: ConditionalTagsExtension when the two were swapped, and every extension registered from a project config file — the compiler always processes those after PHPStan's own. A bad tag then surfaced during analysis as Call to undefined method PHPStan\File\FileExcluderFactory::getNodeType().

Moving the check to afterCompile() — after every extension's beforeCompile(), and still before the tags matter — makes all 20 front/back positions report it, and covers third-party extensions for the first time.

The check now runs after ContainerBuilder::complete(). The test config registered a second autowired FileHelper, making DefaultStubFilesProvider's constructor ambiguous; that used to be masked because validation threw before autowiring ran. autowired: false keeps the fixture focused on the tag.

3. The list itself

The ten extensions now carry #[ContainerExtension(name: '...')] and are registered by ContainerExtensionsExtension, which ContainerFactory installs in the compiler's extensions slot.

Extending Nette's ExtensionsExtension and occupying that slot are both required. Compiler::processExtensions() runs loadConfiguration() on extensions matching ParametersExtension or ExtensionsExtension by instanceof, then snapshots its extension list and rejects later additions with Extensions ... were added while container was being compiled. So a plain CompilerExtension cannot register extensions even from that slot, and a subclass registered through extensions: does not exist yet when the snapshot is taken. Occupying the slot also keeps extensions: sections working — third-party extensions and conf/config.stubValidator.neon — through the parent implementation.

Registration is ordered by name so the container does not depend on the attribute collector's reporting order. That order happens to put autowiredAttributeServices before validateExcludePaths — the combination that was fatal before the first commit.

Verification

• Generated container unchanged: all 600 createService() bodies byte-identical to those built from the extensions: section; reversing the registration order changes nothing either.
• bin/phpstan analyse -l 8 src/Analyser/TypeSpecifier.php src/Rules/Comparison --error-format=json byte-identical to before.
• Full make phpstan clean; 379 tests across DependencyInjection, File, Command, Php, Parallel green; StubValidatorIntegrationTest green (it exercises both the extensions: path and StubValidatorRuleServicesExtension).
• Cold container build unchanged within noise (0.27–0.33s vs 0.27–0.28s over 3 runs); container grows 1.1% as inlined scalars become calls.

Behavior changes worth a look

• A project config listing an extension under a name PHPStan already uses now fails with Name 'rules' is already used or reserved. instead of silently replacing PHPStan's own extension.
• A wrongly tagged service in a config that also breaks autowiring now reports the Nette autowiring error rather than the tag message, since validation moved past complete().
• Adding or renaming a #[ContainerExtension] requires composer dump-autoload, like the other attributes.
• NeonAdapter::CACHE_KEY is bumped once, in the first commit.

Not included

No test pins the order-independence itself — the only way to exercise it is to permute the extensions: block, which no longer exists. Happy to add a unit test over the parameter-reference forms (%a%, %a.b%, %a%/suffix, %%, missing-parameter throw) if you want one.

🤖 Generated with Claude Code

https://claude.ai/code/session_012QftMsBzTZP26Nn77ZxyR6