Skip scope type lookup for expressions without nullsafe operators#6104
Closed
staabm wants to merge 1 commit into
Closed
Skip scope type lookup for expressions without nullsafe operators#6104staabm wants to merge 1 commit into
staabm wants to merge 1 commit into
Conversation
getNullsafeShortcircuitedExprRespectingScope() asked the scope for the expression's type before checking whether the expression contains a nullsafe operator at all. When it does not - the common case for the method/property/offset check rules calling this on every access - the result is the unmodified expression either way, and the type lookup (often a cache miss on the asking scope) is wasted. Do the cheap identity check first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNullsafeShortcircuitedExprRespectingScope() asked the scope for the expression's type before checking whether the expression contains a nullsafe operator at all. When it does not - the common case for the method/property/offset check rules calling this on every access - the result is the unmodified expression either way, and the type lookup (often a cache miss on the asking scope) is wasted. Do the cheap identity check first.
I cannot measure a clear benefit,