test: update literal types after template union fix - #6404
Conversation
|
You've opened the pull request against the latest branch 2.3.x. PHPStan 2.3 is not going to be released for months. If your code is relevant on 2.2.x and you want it to be released sooner, please rebase your pull request and change its target to 2.2.x. |
|
@ondrejmirtes its a 2.3.x only change in expectations. Please have a look |
|
I am not the maintainer, so the semantics call here is Ondřej's. What I can add is where the change comes The transcription is faithful. On The test fails on 2.3.x without the PR and passes with it. On 2.2.x it passes as it stands, so "2.3.x only" Where it started. I bisected The new values follow from the annotations. With
That also explains why only three of the four assertions move. In the first one One thing I checked and it is not the cause. This is not a general shift toward literal template Worth a decision rather than a review comment. The key accumulates across sequential calls, so Nothing to measure here, the PR touches no |
|
Thank you! |
No description provided.