Let a trait-pathed ignore entry take precedence over the class-pathed ones - #6411
Open
mlocati wants to merge 1 commit into
Open
Let a trait-pathed ignore entry take precedence over the class-pathed ones#6411mlocati wants to merge 1 commit into
mlocati wants to merge 1 commit into
Conversation
… ones When a class using a trait reports its own error with the same message and identifier as an error deduplicated directly into the trait, --generate-baseline records the class occurrence under the class path (count: 1) and the deduplicated error under the trait path (count: 1). On re-run the class-pathed entry also absorbed the trait context of that class, so it was reported as expected 1 time but occurred 2 times: the generated baseline failed by itself. An entry scoped to the trait file hides the deduplicated error for every using class, so it is now tried first: the class-pathed entries account only for the errors reported in the class files themselves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class using a trait reports its own error with the same message and identifier as an error deduplicated directly into the trait,
--generate-baselinerecords the class occurrence under the class path (count: 1) and the deduplicated error under the trait path (count: 1)On re-run the class-pathed entry also absorbed the trait context of that class, so it was reported as expected 1 time but occurred 2 times: the generated baseline failed by itself.
An entry scoped to the trait file hides the deduplicated error for every using class, so it is now tried first: the class-pathed entries account only for the errors reported in the class files themselves.