Bitwise flags not working quite well with self::CONST_*

[Seldaek]

Bug report

Bitwise flags are not working together with self::CONST_* - sorry if I missed something in the type docs that helps declare this better. I don't know if it needs a new type to specify ints that are bit masks or what exactly. Might be a feature request rather than bug report.. Psalm seems to output the same error, so maybe I'm the problem, but it doesn't seem to be that unreasonable to list all valid constants that can be passed in, without listing all possible combinations or just typing it as an int. Listing constants helps with auto-completion and self-documentation so it'd be great to be able to.

Code snippet that reproduces the problem

https://phpstan.org/r/ab87e34e-a3c2-4afe-a7cd-f77f8406df27

Expected output

No error

[Seldaek]

Seems that how Psalm implemented it as int-mask<X, Y> or int-mask-of<Foo::CONST_*> is pretty reasonable (https://github.com/vimeo/psalm/blob/4.x/src/Psalm/Type/Atomic/TIntMaskOf.php & https://github.com/vimeo/psalm/blob/4.x/src/Psalm/Type/Atomic/TIntMask.php).

[ondrejmirtes]

So given 1, 2, 4, 8, we just need to generate an integer range int<1, 15>? Doesn't look that hard 😊

[Seldaek]

Yeah I think that's the summary of their model, tho maybe @orklah can confirm..

It should be int<0,15> though as you want to allow representing the absence of any flags.

[cmb69]

Might not be quite that simple in practice, if there are missing flag values (e.g. because a flag has been removed at some point in time).

[orklah]

Yeah, Psalm doesn't resolve the mask until the last moment and then resolve it with a list of literals instead of a range (to be able to handle missing values for example)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.