Always evaluated scope is not detected if condition is stronger

[mvorisek]

Bug report

in the repro, there are two methods with the same code, in the 2nd method, an extra condition is added making the condition later stronger - but phpstan does handle it as weaker

Code snippet that reproduces the problem

https://phpstan.org/r/0715a034-ace4-4d2b-8099-05c6d34613ea

Expected output

no phpstan error

[mvorisek]

another repro: https://phpstan.org/r/412b11c8-d545-4152-b629-46f5e9544846

[phpstan-bot]

@mvorisek After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.4 (3 errors)
+==========
+
+24: Deprecated in PHP 8.4: Parameter #1 $field (string) is implicitly nullable via default value null.
+39: Variable $scopeRestored might not be defined.
+47: Variable $scopeRestored might not be defined.
+
 PHP 8.0 – 8.3 (2 errors)
 ==========
 

Full report

PHP 8.4 (3 errors)

Line	Error
24	Deprecated in PHP 8.4: Parameter #1 $field (string) is implicitly nullable via default value null.
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.

PHP 8.0 – 8.3 (2 errors)

Line	Error
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.

PHP 7.2 – 7.4 (3 errors)

Line	Error
4	Promoted properties are supported only on PHP 8.0 and later.
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.

[phpstan-bot]

@mvorisek After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.4 – 8.5 (3 errors)
+==========
+
+24: Deprecated in PHP 8.4: Parameter #1 $field (string) is implicitly nullable via default value null.
+39: Variable $scopeRestored might not be defined.
+47: Variable $scopeRestored might not be defined.
+
 PHP 8.0 – 8.3 (2 errors)
 ==========
 

Full report

PHP 8.4 – 8.5 (3 errors)

Line	Error
24	Deprecated in PHP 8.4: Parameter #1 $field (string) is implicitly nullable via default value null.
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.

PHP 8.0 – 8.3 (2 errors)

Line	Error
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.

PHP 7.2 – 7.4 (3 errors)

Line	Error
4	Promoted properties are supported only on PHP 8.0 and later.
39	Variable $scopeRestored might not be defined.
47	Variable $scopeRestored might not be defined.